Re: [PATCH] gnu: wireless-tools: Install the manual pages under $out/share/man

[ludo@gnu.org (Ludovic Courtès)]

宋文武 <iyzsong@gmail.com> skribis:

> From f961e72823cda48406d0058902c67b6b663da791 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@gmail.com>
> Date: Sat, 29 Nov 2014 12:52:59 +0800
> Subject: [PATCH] gnu: wireless-tools: Install the manual pages under
>  $out/share/man.
>
> * gnu/packages/linux.scm (wireless-tools)[origin]: Add snippet.

Thanks, applied.

It may be a good time to get commit access.  Could you create an account
on Savannah and let me know?

> We could get rid of MANPATH, if all man pages install to $out/share/man.

Yes, it’s always been the goal to uniformly use share/man.

In core-updates, I’d like to add a build phase at the very end that
checks a few things like that, and aborts on failure.  WDYT?

> Assume a suitable PATH is set, try:
>   $ guix package -r wireless-tools
>   $ env MANPATH= manpath
> Get:
>   /run/current-system/profile/man:/home/iyzsong/.guix-profile/share/man
> It's because wireless-tools having man pages in $out/man, after apply
> this patch, we should get:
>   /run/current-system/profile/share/man:/home/iyzsong/.guix-profile/share/man
> 
> Then `man' will just work even without MANPATH.

Indeed.  I didn’t know MANPATH was unneeded in this case.

Thanks!

Ludo’.