From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add numpy.
Date: Mon, 01 Dec 2014 21:34:10 +0100
Message-ID: <87iohvjeil.fsf@gnu.org>
References: <CAKrPhPO2oX3-h3p9mgAHE-e9r=5sDKvw0tM4kz0oQrBN4AL6hQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38038)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XvXfm-0007OT-M0
	for guix-devel@gnu.org; Mon, 01 Dec 2014 15:34:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XvXfh-0001gJ-N9
	for guix-devel@gnu.org; Mon, 01 Dec 2014 15:34:18 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:45134)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XvXfh-0001fw-Gp
	for guix-devel@gnu.org; Mon, 01 Dec 2014 15:34:13 -0500
In-Reply-To: <CAKrPhPO2oX3-h3p9mgAHE-e9r=5sDKvw0tM4kz0oQrBN4AL6hQ@mail.gmail.com>
	(Federico Beffa's message of "Mon, 1 Dec 2014 18:17:14 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Federico Beffa <beffa@ieee.org>
Cc: Guix-devel <guix-devel@gnu.org>

Federico Beffa <beffa@ieee.org> skribis:

> From cdf0c1a3193d1855d8b1a512042f91a56c82ea28 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <beffa@fbengineering.ch>
> Date: Mon, 1 Dec 2014 13:28:24 +0100
> Subject: [PATCH] gnu: Add numpy.
>
> * gnu/packages/python.scm (python-numpy, python2-numpy): New variables.

[...]

> +                    ;; Generation of the info file fails.

Please add FIXME or XXX.  =E2=86=91

> +                    (map (lambda (file)
> +                           (copy-file (string-append "build/latex" file)
> +                                      (string-append doc file)))
> +                           '("/numpy-ref.pdf" "/numpy-user.pdf"))

Please use =E2=80=98for-each=E2=80=99 instead of =E2=80=98map=E2=80=99 (bec=
ause it=E2=80=99s a for-effect
iteration), and align the file list with =E2=80=9C(lambda=E2=80=9D.

> +                      (map (lambda (file)

=E2=80=98for-each=E2=80=99 as well.

OK to push with these changes.

Thanks!

Ludo=E2=80=99.