From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] Add upower Date: Sun, 05 Apr 2015 11:07:43 -0400 Message-ID: <87ioda62bk.fsf@netris.org> References: <87egnz4qgt.fsf@pobox.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yem93-0002Sk-UZ for guix-devel@gnu.org; Sun, 05 Apr 2015 11:07:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yem90-0002qW-Lw for guix-devel@gnu.org; Sun, 05 Apr 2015 11:07:29 -0400 Received: from world.peace.net ([50.252.239.5]:55963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yem90-0002kV-IN for guix-devel@gnu.org; Sun, 05 Apr 2015 11:07:26 -0400 In-Reply-To: <87egnz4qgt.fsf@pobox.com> (Andy Wingo's message of "Sat, 04 Apr 2015 21:56:50 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andy Wingo Cc: guix-devel@gnu.org Hi Andy! Here are some more comments to add to David's: Andy Wingo writes: > From 4725d267b7c18bc4ba4294f90336871311386bb2 Mon Sep 17 00:00:00 2001 > From: Andy Wingo > Date: Sat, 4 Apr 2015 21:48:01 +0200 > Subject: [PATCH 2/3] Add upower package. By our conventions, we write this first line as: "gnu: Add upower." > * gnu/packages/gnome.scm (upower): New variable. > * gnu/packages/patches/upower-builddir.patch: New patch. The patch also needs to be added to 'dist_patch_DATA' in gnu-system.am. David Thompson wrote: > Could you add a comment about the upstream status of this patch, perhaps > with a URL pointing to the relevant bug tracker, if applicable? Agreed, but I think this should go in the top of the patch file rather than in the package definition itself. Thanks! Mark