From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH]: gnu: shogun: Remove non-free source files. Date: Sat, 09 May 2015 23:06:29 +0200 Message-ID: <87ioc1v4tm.fsf@mango.localdomain> References: <87a8xeqqk7.fsf@netris.org> <871tipj1xq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrBxP-0007fL-5b for guix-devel@gnu.org; Sat, 09 May 2015 17:06:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrBxO-0008K7-ET for guix-devel@gnu.org; Sat, 09 May 2015 17:06:47 -0400 In-reply-to: <871tipj1xq.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel Ludovic Courtès writes: >>> There are functions in src/shogun/kernel/Kernel.{cpp,h} that are also >>> released under non-free terms, but they are enclosed in #ifdef >>> statements and the make flags we pass disable these functions at build >>> time. >> >> This is not sufficient. We will need to completely remove the non-free >> functions from the source code using a snippet. We cannot use a patch >> because the patch would contain the non-free code. > Ricardo: could you look into it? Yes, I'll take care of this. I'll try to have a patch ready in a couple of days. ~~ Ricardo