From: ludo@gnu.org (Ludovic Courtès)
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel <Guix-devel@gnu.org>
Subject: Re: [PATCH 01/10] gnu: base: Pass PATH_MAX TO sed and patch.
Date: Tue, 19 May 2015 18:17:54 +0200 [thread overview]
Message-ID: <87iobofsnh.fsf@gnu.org> (raw)
In-Reply-To: <CAFtzXzMo_2evZ0yTDbh4nqqGWRc11Ob8e435F1o6ZJhuXBUpEQ@mail.gmail.com> (Manolis Ragkousis's message of "Tue, 19 May 2015 01:15:05 +0300")
Manolis Ragkousis <manolis837@gmail.com> skribis:
> From 4eb7220772b5ddb916debb5577ebc8febbba55b4 Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Sun, 3 May 2015 22:02:12 +0300
> Subject: [PATCH 01/10] gnu: base: Pass PATH_MAX TO sed and patch.
>
> * gnu/packages/base.scm (sed): Pass PATH_MAX to configure.
> * gnu/packages/base.scm (patch): Same.
[...]
> + '(#:configure-flags '("CPPFLAGS=-DPATH_MAX=4096"))
> `(#:phases (alist-cons-before
> 'patch-source-shebangs 'patch-test-suite
> (lambda* (#:key inputs #:allow-other-keys)
> @@ -165,6 +165,8 @@ standard utility.")
> (base32
> "16d2r9kpivaak948mxzc0bai45mqfw73m113wrkmbffnalv1b5gx"))))
> (build-system gnu-build-system)
> + (arguments
> + `(#:configure-flags '("CPPFLAGS=-DPATH_MAX=4096")))
Could you make sure ‘PATH_MAX’ is only defined on GNU/Hurd?
It might be best to just come up with a patch to the source. For Guix,
an acceptable patch is just:
#ifndef PATH_MAX
# define PATH_MAX 4096
#endif
added in the right place.
The ideal patch for upstream is something that uses malloc and similar
instead of fixed-length arrays.
Thanks,
Ludo’.
prev parent reply other threads:[~2015-05-19 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 22:15 [PATCH 01/10] gnu: base: Pass PATH_MAX TO sed and patch Manolis Ragkousis
2015-05-19 16:17 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iobofsnh.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=Guix-devel@gnu.org \
--cc=manolis837@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).