Re: [PATCH] Add skalibs, execline.

[ludo@gnu.org (Ludovic Courtès)]

"Claes Wallin (韋嘉誠)" <gnu@clacke.user.lysator.liu.se> skribis:

> From 9a290c4e798a4668cae65126d48d301b44b96a69 Mon Sep 17 00:00:00 2001
> From: Claes Wallin <claes.wallin@greatsinodevelopment.com>
> Date: Thu, 25 Jun 2015 12:00:06 +0200
> Subject: [PATCH 1/3] gnu: Add skalibs.
>
>  * gnu/package/skarnet.scm (skalibs): New file.
>  * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

[...]

> +    (search-paths
> +     (list (search-path-specification
> +            (variable "CPATH")
> +            (files '("include")))
> +           (search-path-specification
> +            (variable "LIBRARY_PATH")
> +            (files '("lib")))))

This is not needed here (‘gcc’ handles that.)

> +    (synopsis "Common libraries for skarnet.org software")
> +    (description
> +     "General-purpose libraries for minimalist C development, used by all
> +      skarnet.org software.")
   ^^^^^^
Please remove extra space here.

Also, what about something like:

  This package provides lightweight C libraries for <list examples of
  features, like data structures and such>.  They are used by
  skarnet.org software.

> From 75b13e87271f8b8b0f54562a46aa6e7e437aacb9 Mon Sep 17 00:00:00 2001
> From: Claes Wallin <claes.wallin@greatsinodevelopment.com>
> Date: Thu, 25 Jun 2015 14:47:41 +0200
> Subject: [PATCH 2/3] gnu: Add execline.
>
>  * gnu/package/skarnet.scm (execline): New variable.
  ^
Extra space.

> diff --git a/gnu/packages/patches/execline-fix-gen-deps.patch b/gnu/packages/patches/execline-fix-gen-deps.patch
> new file mode 100644
> index 0000000..79bdc95
> --- /dev/null
> +++ b/gnu/packages/patches/execline-fix-gen-deps.patch
> @@ -0,0 +1,12 @@

Please start the .patch with a brief description of what it does, and
its upstream status (like “Upstream commit XYZ”, or “Submitted upstream
at http://...”.)

> +       #:modules ((guix build utils)
> +                  (guix build gnu-build-system)
> +                  (ice-9 popen))

Replace the first two with:

  ,@%gnu-build-system-modules

and use a backquote instead of a quote in ‘arguments.’

> +     "Execline is a (non-interactive) scripting language, like sh, but its
> +syntax is quite different from a traditional shell syntax.  The execlineb
> +program is used strictly as a parser for a text file and generates a single
> +command execution with the entire script stored in the argument array.
> +The language is a library of binaries useful for the tail call or 
> +chain execution style that the parser requires.
> +
> +It is as powerful as a shell: It features conditional loops,
> +getopt-style option handling, filename globbing, and more.  Meanwhile, its
> +syntax is unambiguous and simple, allowing a minimal parser, which doesn't
> +even stay in memory when parsing is done and execution starts.")))

s/filename/file name/
It would be nice to make it a couple of lines shorter.

> From e39ab44b8464aa14b25fc8554facd34411b926eb Mon Sep 17 00:00:00 2001
> From: Claes Wallin <claes.wallin@greatsinodevelopment.com>
> Date: Fri, 26 Jun 2015 00:45:41 +0200
> Subject: [PATCH 3/3] gnu: make execline commands trivially available to all
>  execline scripts
>
>  * gnu/package/skarnet.scm (execline): wrap execlineb to have its own
>                                        .../bin first in PATH

LGTM, but please merge it with the previous patch.

Could you send updated patches?

Thank you!

Ludo’.