From: Alex Kost <alezost@gmail.com>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: pdf: Fix installing desktop files of zathura packages.
Date: Tue, 07 Jul 2015 20:39:51 +0300 [thread overview]
Message-ID: <87io9vj28o.fsf@gmail.com> (raw)
In-Reply-To: <87zj380zxg.fsf@netris.org> (Mark H. Weaver's message of "Tue, 07 Jul 2015 11:07:07 -0400")
Mark H Weaver (2015-07-07 18:07 +0300) wrote:
[...]
>> (arguments
>> `(#:make-flags
>> `(,(string-append "DESTDIR=" (assoc-ref %outputs "out"))
>> - "PLUGINDIR=/lib/zathura" "CC=gcc")
>> + "PREFIX=" "PLUGINDIR=/lib/zathura" "CC=gcc")
>
> It would be better to leave DESTDIR empty and set PREFIX=<%output>, so:
It wouldn't work for these packages.
>> - `(,(string-append "DESTDIR=" (assoc-ref %outputs "out"))
>> + `(,(string-append "PREFIX=" (assoc-ref %outputs "out"))
>
> There is a conceptual difference between PREFIX and DESTDIR: at install
> time, files are copied to ${DESTDIR}${PREFIX}, and then at run time
> files are expected to be at ${PREFIX}. So in general, we don't want to
> use DESTDIR in Guix, and we want to set PREFIX to the output directory.
I know, but these zathura plugins do not provide configure stages, and
PREFIX is not even used in the manually written "Makefile"s. PREFIX is
used in "config.mk" (which is included in a Makefile) to define LIBDIR
and DESKTOPPREFIX.
And due to Makefile things are installed in ${DESTDIR}${PLUGINDIR} and
${DESTDIR}${DESKTOPPREFIX}.
--
Alex
next prev parent reply other threads:[~2015-07-07 17:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 8:33 [PATCH] gnu: pdf: Fix installing desktop files of zathura packages Alex Kost
2015-07-07 8:43 ` Paul van der Walt
2015-07-07 17:40 ` Alex Kost
2015-07-07 15:07 ` Mark H Weaver
2015-07-07 17:39 ` Alex Kost [this message]
2015-07-07 18:36 ` Mark H Weaver
2015-07-07 19:25 ` Alex Kost
2015-07-07 19:59 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87io9vj28o.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).