unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Allan Webber <cwebber@dustycloud.org>
To: guix-devel@gnu.org
Subject: [PATCH] emacs: Fix reference to directory variable
Date: Sun, 19 Jul 2015 13:23:02 -0500	[thread overview]
Message-ID: <87io9g6m3b.fsf@dustycloud.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

Hello,

I noticed that guix's emacs mode contained a bug which prevented my full
emacs config from loading... turns out it was due to a variable
reference to a variable which had recently been renamed, thus turning a
small warning message into an unintentional error! :)

A small fix is below.
 - Chris


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-emacs-Fix-reference-to-directory-variable.patch --]
[-- Type: text/x-diff, Size: 1117 bytes --]

From c935c76e7e45b3ee3b0f191b3e21e041a6404996 Mon Sep 17 00:00:00 2001
From: Christopher Allan Webber <cwebber@dustycloud.org>
Date: Sun, 19 Jul 2015 13:17:44 -0500
Subject: [PATCH] emacs: Fix reference to directory variable

* emacs/guix-emacs.el (guix-emacs-find-autoloads): Fix variable
  reference to 'elisp-root-dir', which kept the old name of 'dir'
  despite having been renamed above.  This had introduced a bug
  where a mundane warning would instead cause a variable reference
  error.
---
 emacs/guix-emacs.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs/guix-emacs.el b/emacs/guix-emacs.el
index 4c3aa23..ddcef0a 100644
--- a/emacs/guix-emacs.el
+++ b/emacs/guix-emacs.el
@@ -69,7 +69,7 @@ Return nil if there are no emacs packages installed in PROFILE."
                                 (guix-emacs-subdirs elisp-pkgs-dir))))
                 (append root-autoloads pkgs-autoloads))
             root-autoloads))
-      (message "Directory '%s' does not exist." dir)
+      (message "Directory '%s' does not exist." elisp-root-dir)
       nil)))
 
 ;;;###autoload
-- 
2.1.4


             reply	other threads:[~2015-07-19 18:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-19 18:23 Christopher Allan Webber [this message]
2015-07-19 18:59 ` [PATCH] emacs: Fix reference to directory variable Mathieu Lirzin
2015-07-20  8:51 ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87io9g6m3b.fsf@dustycloud.org \
    --to=cwebber@dustycloud.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).