From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 2/3] gnu: Update python-fixtures Date: Sun, 27 Sep 2015 22:17:12 +0200 Message-ID: <87io6vy5vb.fsf@gnu.org> References: <1442874675-31473-1-git-send-email-tipecaml@gmail.com> <1442874675-31473-3-git-send-email-tipecaml@gmail.com> <5601CC0B.3090601@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgINo-0002cA-0z for guix-devel@gnu.org; Sun, 27 Sep 2015 16:17:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZgINn-00044o-5k for guix-devel@gnu.org; Sun, 27 Sep 2015 16:17:15 -0400 In-Reply-To: <5601CC0B.3090601@gmail.com> (Cyril Roelandt's message of "Tue, 22 Sep 2015 23:45:47 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Cyril Roelandt Cc: guix-devel Cyril Roelandt skribis: > On 09/22/2015 09:16 PM, Thompson, David wrote: >> On Mon, Sep 21, 2015 at 6:31 PM, Cyril Roelandt wro= te: >>> * gnu/packages/python.scm (python-fixtures): Update. >>> * gnu/packages/python.scm (python-fixtures-0.3.16, >>> python2-fixtures-0.3.16, python-pbr-0.11, >>> python2-pbr-0.11): New variables. >>> * gnu/packages/python.scm (python-testrepository): Use python-fxitures-= 0.3.16 >>> instead of python-fixtures in the inputs. >>=20 >> One package update or new package per patch, please. >>=20 > > I know it is usually done like this, but I feel this is a bit special, > since all these changes are only done in order to update > python-fixtures. I could have: > > 1) renamed python-fixtures to python-fixtures-0.3.16 and changed inputs > from "python-fixtures" to "python-fixtures-0.3.16" for all packages that > depend on fixtures > 2) added python-pbr-0.11 > 3) added python-fixtures > 4) changed inputs from "python-fixtures-0.3.16" to "python-fixtures" for > all packages that depend on fixtures > > But I feel it would be incredibly confusing when looking at "git log". WD= YT? Yeah, two commits would do IMO: one to add python-pbr-0.11, and the other one for the rest. Could you do that? This patch series needs to go in before it accumulates dust. Thanks, Ludo=E2=80=99.