From: ludo@gnu.org (Ludovic Courtès)
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 2/3] gnu: Update python-fixtures
Date: Sun, 27 Sep 2015 22:17:12 +0200 [thread overview]
Message-ID: <87io6vy5vb.fsf@gnu.org> (raw)
In-Reply-To: <5601CC0B.3090601@gmail.com> (Cyril Roelandt's message of "Tue, 22 Sep 2015 23:45:47 +0200")
Cyril Roelandt <tipecaml@gmail.com> skribis:
> On 09/22/2015 09:16 PM, Thompson, David wrote:
>> On Mon, Sep 21, 2015 at 6:31 PM, Cyril Roelandt <tipecaml@gmail.com> wrote:
>>> * gnu/packages/python.scm (python-fixtures): Update.
>>> * gnu/packages/python.scm (python-fixtures-0.3.16,
>>> python2-fixtures-0.3.16, python-pbr-0.11,
>>> python2-pbr-0.11): New variables.
>>> * gnu/packages/python.scm (python-testrepository): Use python-fxitures-0.3.16
>>> instead of python-fixtures in the inputs.
>>
>> One package update or new package per patch, please.
>>
>
> I know it is usually done like this, but I feel this is a bit special,
> since all these changes are only done in order to update
> python-fixtures. I could have:
>
> 1) renamed python-fixtures to python-fixtures-0.3.16 and changed inputs
> from "python-fixtures" to "python-fixtures-0.3.16" for all packages that
> depend on fixtures
> 2) added python-pbr-0.11
> 3) added python-fixtures
> 4) changed inputs from "python-fixtures-0.3.16" to "python-fixtures" for
> all packages that depend on fixtures
>
> But I feel it would be incredibly confusing when looking at "git log". WDYT?
Yeah, two commits would do IMO: one to add python-pbr-0.11, and the
other one for the rest.
Could you do that? This patch series needs to go in before it
accumulates dust.
Thanks,
Ludo’.
next prev parent reply other threads:[~2015-09-27 20:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 22:31 [PATCH 0/3] Add python-bandit Cyril Roelandt
2015-09-21 22:31 ` [PATCH 1/3] gnu: Add python-pip Cyril Roelandt
2015-09-22 14:30 ` Mathieu Lirzin
2015-09-21 22:31 ` [PATCH 2/3] gnu: Update python-fixtures Cyril Roelandt
2015-09-22 15:11 ` Mathieu Lirzin
2015-09-22 19:16 ` Thompson, David
2015-09-22 21:45 ` Cyril Roelandt
2015-09-27 20:17 ` Ludovic Courtès [this message]
2015-10-08 21:41 ` Cyril Roelandt
2015-10-09 12:18 ` Ludovic Courtès
2015-09-21 22:31 ` [PATCH 3/3] gnu: Add python-bandit Cyril Roelandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87io6vy5vb.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=tipecaml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).