From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul van der Walt <paul@denknerd.org>
Subject: Re: [PATCH] gnu: Add dosbox x86 emulator.
Date: Thu, 22 Oct 2015 11:13:46 +0200
Message-ID: <87io5zs1th.fsf@denknerd.org>
References: <1445261129-27744-1-git-send-email-paul@denknerd.org>
	<87bnbrn8v2.fsf@netris.org>
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56610)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpBwZ-0001GS-65
	for guix-devel@gnu.org; Thu, 22 Oct 2015 05:13:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpBwV-0003qB-1Z
	for guix-devel@gnu.org; Thu, 22 Oct 2015 05:13:55 -0400
Received: from mx01.mykolab.com ([95.128.36.1]:59237 helo=mx-out02.mykolab.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@denknerd.org>) id 1ZpBwU-0003pO-Rn
	for guix-devel@gnu.org; Thu, 22 Oct 2015 05:13:50 -0400
In-reply-to: <87bnbrn8v2.fsf@netris.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel@gnu.org

Hi Mark,

On 2015-10-22 at 00:40, quoth Mark H Weaver:
>> +    (arguments
>> +     `(#:phases (modify-phases %standard-phases
>> +                  (add-before
>> +                   'configure 'autogen.sh
>> +                   (lambda _
>> +                     (zero? (system* "sh" "autogen.sh")))))))
>
> For future reference, phases like the one above, that generates the
> configure script, should always be put after 'unpack' instead of before
> 'configure'.  The reason is that there are some phases between the
> 'unpack' and 'configure' phases that are needed to fix things up in the
> generated 'configure' script for non-Intel platforms, especially
> 'patch-usr-bin-file' which is typically needed on MIPS.
>
> I went ahead and made this change in commit e0a7d36458.

Right, sorry about that, and thank you very much!

p.