From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: ffmpeg: Move flags into their own argument.
Date: Thu, 29 Oct 2015 22:11:48 +0100
Message-ID: <87io5p752j.fsf@gnu.org>
References: <20151028233651.112ce6cf@uwaterloo.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50836)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZruUG-0004mY-K4
	for guix-devel@gnu.org; Thu, 29 Oct 2015 17:11:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1ZruUB-0000Xo-G4
	for guix-devel@gnu.org; Thu, 29 Oct 2015 17:11:56 -0400
In-Reply-To: <20151028233651.112ce6cf@uwaterloo.ca> (Andy Patterson's message
	of "Wed, 28 Oct 2015 23:36:51 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Andy Patterson <ajpatter@uwaterloo.ca>
Cc: guix-devel@gnu.org

Andy Patterson <ajpatter@uwaterloo.ca> skribis:

> The reason I wanted to do this was so that I could enable TLS support
> for ffmpeg locally. The comment in the configure flags specifies that
> the tests fail with gnutls support enabled. The tests are currently
> working for me with gnutls enabled, on AMD64. I'd like to send another
> patch to enable it. Does anyone have any concerns about doing so?

It turns out that FFmpeg already depends on GnuTLS via libquvi, per:

  guix graph -t references ffmpeg | dot -Tps > t.ps

So I would say that you can add it in a separate patch without any
problems.

> From c78491cc816d936722ec403e8bd498162abcf962 Mon Sep 17 00:00:00 2001
> From: Andy Patterson <ajpatter@uwaterloo.ca>
> Date: Wed, 28 Oct 2015 22:42:42 -0400
> Subject: [PATCH] gnu: ffmpeg: Move flags into their own argument.
>
> * gnu/packages/video.scm (ffmpeg)[arguments]: Move the configurable
>   configure flag literals into the configure-flags argument. Call
>   configure with these flags from the configure phase.

Applied, thanks!

Ludo=E2=80=99.