From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/3] system: Add /etc/environment.
Date: Fri, 04 Dec 2015 15:33:39 +0100
Message-ID: <87io4ejnb0.fsf@gnu.org>
References: <1449063511-689-1-git-send-email-iyzsong@gmail.com>
	<1449063511-689-2-git-send-email-iyzsong@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58426)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1a4yWy-0002CX-UD
	for guix-devel@gnu.org; Fri, 04 Dec 2015 17:08:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1a4yWw-0005Ww-JO
	for guix-devel@gnu.org; Fri, 04 Dec 2015 17:08:44 -0500
In-Reply-To: <1449063511-689-2-git-send-email-iyzsong@gmail.com>
	(=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Wed, 2 Dec 2015 21:38:30 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:

> * gnu/system.scm: (operating-system-environment-variables): New procedure.
> Adapted and moved environment variables from /etc/profile.
> (operating-system-etc-service): Adjust accordingly.
> (essential-services): Add an instance of SESSION-ENVIRONMENT-SERVICE-TYPE.

This looks good, but it must be applied after patch 3/3.  Otherwise,
we=E2=80=99d end up with a system that has an empty /etc/profile and an
/etc/environment file that is not honored.

Makes sense?

Thanks!

Ludo=E2=80=99.