unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: 宋文武 <iyzsong@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/3] system: Add /etc/environment.
Date: Fri, 04 Dec 2015 15:33:39 +0100	[thread overview]
Message-ID: <87io4ejnb0.fsf@gnu.org> (raw)
In-Reply-To: <1449063511-689-2-git-send-email-iyzsong@gmail.com> ("宋文武"'s message of "Wed, 2 Dec 2015 21:38:30 +0800")

宋文武 <iyzsong@gmail.com> skribis:

> * gnu/system.scm: (operating-system-environment-variables): New procedure.
> Adapted and moved environment variables from /etc/profile.
> (operating-system-etc-service): Adjust accordingly.
> (essential-services): Add an instance of SESSION-ENVIRONMENT-SERVICE-TYPE.

This looks good, but it must be applied after patch 3/3.  Otherwise,
we’d end up with a system that has an empty /etc/profile and an
/etc/environment file that is not honored.

Makes sense?

Thanks!

Ludo’.

  reply	other threads:[~2015-12-04 22:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02 13:38 [PATCH 1/3] services: Add 'session-environment-service' 宋文武
2015-12-02 13:38 ` [PATCH 2/3] system: Add /etc/environment 宋文武
2015-12-04 14:33   ` Ludovic Courtès [this message]
2015-12-05  2:55     ` 宋文武
2015-12-02 13:38 ` [PATCH 3/3] system: pam: Honor /etc/environment 宋文武
2015-12-04 14:38   ` Ludovic Courtès
2015-12-02 18:45 ` [PATCH 1/3] services: Add 'session-environment-service' Alex Kost
2015-12-03 11:59   ` 宋文武
2015-12-04 14:29     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87io4ejnb0.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=iyzsong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).