From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 4/6] gnu: Add emacs-constants. Date: Sun, 10 Jan 2016 21:45:37 +0100 Message-ID: <87io312mfi.fsf@gnu.org> References: <87vb77k7bv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aIMrv-0002UE-HT for guix-devel@gnu.org; Sun, 10 Jan 2016 15:45:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aIMrs-0004Zk-AI for guix-devel@gnu.org; Sun, 10 Jan 2016 15:45:43 -0500 In-Reply-To: (Federico Beffa's message of "Sat, 9 Jan 2016 11:42:52 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Federico Beffa Cc: Guix-devel Federico Beffa skribis: > On Tue, Jan 5, 2016 at 11:08 PM, Ludovic Court=C3=A8s wrot= e: >> Federico Beffa skribis: > >>> +(define* (uncompressed-file-fetch url hash-algo hash >>> + #:optional name >>> + #:key (system (%current-system)) >>> + (guile (default-guile))) >>> + (mlet %store-monad ((drv (url-fetch url hash-algo hash name >>> + #:system system >>> + #:guile guile))) >>> + (gexp->derivation (or name (basename url)) >>> + #~(begin >>> + (mkdir #$output) >>> + (setenv "PATH" >>> + (string-append #$gzip "/bin")) >>> + (chdir #$output) >>> + (copy-file #$drv (basename #$url)))))) >> >> The dependency on gzip can be removed. >> >> Also, the second derivation is okay, but kind of wasteful: it only >> serves to move the file in a directory so the patch-application logic >> can work. > > Of course it would be better if the patch logic would recognize this > case. Then we wouldn't need the above procedure. It depends on the maintenance cost, because it=E2=80=99s a rare use case, I= think. >> However, I=E2=80=99m unsure the patch in question really belongs here. = After >> all, there=E2=80=99s just one file, and additionally it=E2=80=99s called= =E2=80=98constants.el=E2=80=99! >> ;-) > > I'm not sure I understand what you are trying to say. Could you please > be more explicit. [...] >> https://github.com/emacsmirror/constants/blob/master/constants.el >> >> Is the patch yours? If yes, could you find an upstream to submit it >> too? If there=E2=80=99s no such thing, you could always become the upst= ream. >> ;-) > > The above URL is just a snapshot of the file. No activity whatsoever. > > Yes, the patch is mine, following suggestions in the file itself. It > is to make the package usable with lisp like syntax so that you don't > get e.g.: > > c =3D 2.99...e8 > > when you insert a constant in a scheme/lisp buffer. Isn't this project > fanatic about scheme? ;-) It is! :-) > I don't think there is an upstream. In any case I have no intention of > becoming one. You=E2=80=99re effectively becoming one, though. Could get in touch with Carsten Dominik, for instance, and propose the patch? If he has no interest or is unresponsive, then we can choose to maintain it in Guix as you propose. But since the changes are not Guix-specific in any way, I think our job is to first try to get it upstream. Does that make sense? Thanks, Ludo=E2=80=99.