unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Federico Beffa <beffa@ieee.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 4/6] gnu: Add emacs-constants.
Date: Sun, 10 Jan 2016 21:45:37 +0100	[thread overview]
Message-ID: <87io312mfi.fsf@gnu.org> (raw)
In-Reply-To: <CAKrPhPO4Tkyx6HpqLSbQg+q42FLxXzKfHgxOPN8zindM6TTP5g@mail.gmail.com> (Federico Beffa's message of "Sat, 9 Jan 2016 11:42:52 +0100")

Federico Beffa <beffa@ieee.org> skribis:

> On Tue, Jan 5, 2016 at 11:08 PM, Ludovic Courtès <ludo@gnu.org> wrote:
>> Federico Beffa <beffa@ieee.org> skribis:
>
>>> +(define* (uncompressed-file-fetch url hash-algo hash
>>> +                                  #:optional name
>>> +                                  #:key (system (%current-system))
>>> +                                  (guile (default-guile)))
>>> +  (mlet %store-monad ((drv (url-fetch url hash-algo hash name
>>> +                                      #:system system
>>> +                                      #:guile guile)))
>>> +    (gexp->derivation (or name (basename url))
>>> +                      #~(begin
>>> +                          (mkdir #$output)
>>> +                          (setenv "PATH"
>>> +                                  (string-append #$gzip "/bin"))
>>> +                          (chdir #$output)
>>> +                          (copy-file #$drv (basename #$url))))))
>>
>> The dependency on gzip can be removed.
>>
>> Also, the second derivation is okay, but kind of wasteful: it only
>> serves to move the file in a directory so the patch-application logic
>> can work.
>
> Of course it would be better if the patch logic would recognize this
> case. Then we wouldn't need the above procedure.

It depends on the maintenance cost, because it’s a rare use case, I think.

>> However, I’m unsure the patch in question really belongs here.  After
>> all, there’s just one file, and additionally it’s called ‘constants.el’!
>> ;-)
>
> I'm not sure I understand what you are trying to say. Could you please
> be more explicit.

[...]

>>   https://github.com/emacsmirror/constants/blob/master/constants.el
>>
>> Is the patch yours?  If yes, could you find an upstream to submit it
>> too?  If there’s no such thing, you could always become the upstream.
>> ;-)
>
> The above URL is just a snapshot of the file. No activity whatsoever.
>
> Yes, the patch is mine, following suggestions in the file itself. It
> is to make the package usable with lisp like syntax so that you don't
> get e.g.:
>
> c = 2.99...e8
>
> when you insert a constant in a scheme/lisp buffer. Isn't this project
> fanatic about scheme? ;-)

It is!  :-)

> I don't think there is an upstream. In any case I have no intention of
> becoming one.

You’re effectively becoming one, though.

Could get in touch with Carsten Dominik, for instance, and propose the
patch?

If he has no interest or is unresponsive, then we can choose to maintain
it in Guix as you propose.  But since the changes are not Guix-specific
in any way, I think our job is to first try to get it upstream.

Does that make sense?

Thanks,
Ludo’.

  reply	other threads:[~2016-01-10 20:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-30 17:33 [PATCH 4/6] gnu: Add emacs-constants Federico Beffa
2016-01-05 22:08 ` Ludovic Courtès
2016-01-09 10:42   ` Federico Beffa
2016-01-10 20:45     ` Ludovic Courtès [this message]
2016-02-03  9:53       ` Federico Beffa
2016-02-03 21:52         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87io312mfi.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=beffa@ieee.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).