From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Lirzin Subject: Re: [PATCH] gnu: powertop: Patch absolute file names. Date: Tue, 19 Apr 2016 11:29:33 +0200 Message-ID: <87inzeeyki.fsf@gnu.org> References: <1461013301-13196-1-git-send-email-mthl@gnu.org> <87d1pmyvc5.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asRyZ-0004bi-MI for guix-devel@gnu.org; Tue, 19 Apr 2016 05:29:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1asRyV-0002Iw-Gs for guix-devel@gnu.org; Tue, 19 Apr 2016 05:29:43 -0400 In-Reply-To: <87d1pmyvc5.fsf@elephly.net> (Ricardo Wurmus's message of "Tue, 19 Apr 2016 08:19:06 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org Ricardo Wurmus writes: > Mathieu Lirzin writes: > >> * gnu/packages/linux.scm (powertop)[inputs]: Add kmod. >> [arguments]: Patch absolute file names. Before that launching powertop >> was failing because 'modprobe' was not found. > > Looks good to me, but I have one thing to nitpick below. > >> + (lambda* (#:key inputs #:allow-other-keys) >> + (let ((kmod (assoc-ref inputs "kmod"))) >> + (substitute* (find-files "src" ".*\\.cpp" ) >> + (("/sbin/modprobe") (string-append kmod "/bin/modprobe= ")) >> + ;; These programs are only needed to calibrate, so usi= ng >> + ;; relative file names avoids adding extra inputs. Wh= en they >> + ;; are missing powertop gracefully handle it. > > Should it not be =E2=80=9Chandles=E2=80=9D? Indeed you are right. :) Thanks for your review. --=20 Mathieu Lirzin