From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Nieuwenhuizen Subject: Re: [PATCH 08/10] gnu: readline: support mingw. Date: Mon, 02 May 2016 21:25:36 +0200 Message-ID: <87inyww9cf.fsf@drakenvlieg.flower> References: <1461942751-23883-1-git-send-email-janneke@gnu.org> <1461942751-23883-8-git-send-email-janneke@gnu.org> <87mvo8naj2.fsf@igalia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axJU9-0005B9-8Q for guix-devel@gnu.org; Mon, 02 May 2016 15:26:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axJTx-0001yh-Hx for guix-devel@gnu.org; Mon, 02 May 2016 15:26:19 -0400 In-Reply-To: <87mvo8naj2.fsf@igalia.com> (Andy Wingo's message of "Mon, 02 May 2016 10:12:33 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Andy Wingo Cc: guix-devel@gnu.org Andy Wingo writes: >> * gnu/packages/patches/readline-6.3-mingw.patch: New file. >> * gnu-system.am (dist_patch_DATA): Add it. >> * gnu/packages/readline.scm (readline): Support mingw. > > Can you clarify the licensing on the patch, and note its original > author? Ideally we should send the patch upstream, too. Oops, didn't mean to snip this. I mailed Alexey Pavlov and didn't get a response yet. I found an earlier patch that this seems to add a bit too. As you can see, it's #ifdef'ing out macros that are missing on mingw: S_ISUID, S_ISGID, S_ISLNK, S_ISSOCK. And now that I look into it, also some that were missing but are now present: SIGHUP, SIGQUIT. And defining S_ISDIR which is a straight copy from stat.h, but is now present in mingw too. Another possibility would be to just patch those macros into mingw's stat.h and drop this patch. WDYT? Jan --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.nl= =20=20