From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu: Add Red Eclipse. Date: Wed, 04 May 2016 11:32:08 +0300 Message-ID: <87inyugr5j.fsf@gmail.com> References: <20160423022054.16f7aeb7@openmailbox.org> <571B21C8.3050100@gmx.net> <20160423074645.545cb512@openmailbox.org> <87eg9sd5zq.fsf@gmail.com> <20160502103837.GA4942@solar> <20160503121022.71dde468@openmailbox.org> <87bn4n9cxn.fsf@gmail.com> <20160503192317.GA5737@solar> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axsEb-0002ki-8B for guix-devel@gnu.org; Wed, 04 May 2016 04:32:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axsEP-0005Fn-3S for guix-devel@gnu.org; Wed, 04 May 2016 04:32:35 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:35611) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axsEN-0005C7-OO for guix-devel@gnu.org; Wed, 04 May 2016 04:32:29 -0400 Received: by mail-lf0-x241.google.com with SMTP id u64so4916497lff.2 for ; Wed, 04 May 2016 01:32:13 -0700 (PDT) In-Reply-To: <20160503192317.GA5737@solar> (Andreas Enge's message of "Tue, 3 May 2016 21:23:17 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Andreas Enge Cc: guix-devel@gnu.org Andreas Enge (2016-05-03 22:23 +0300) wrote: > On Tue, May 03, 2016 at 10:08:52PM +0300, Alex Kost wrote: >> Only the package name is renamed here. I think it would be more >> consistent to rename the variable as well. > > My apologies, indeed. I will push an additional patch. I see, thanks! > On Tue, May 03, 2016 at 10:09:40PM +0300, Alex Kost wrote: >> Probably; you are the master of guidelines, so I trust your judge :-) >> OTOH we also have such packages as 'accountsservice', 'recordmydesktop', >> 'randomjungle', 'rubberband' and others. Should they also be renamed to >> 'accounts-service', 'record-my-desktop', 'random-jungle', 'rubber-band', > > It depends; I just noticed for red-eclipse since you brought up the question. > Now I just checked accountsservice: > (uri (string-append "https://www.freedesktop.org/software/" > name "/" name "-" version ".tar.xz")) > (description > "The AccountService project provides a set of D-Bus interfaces for querying > It looks as if this should remain accountservice, since there is no space > in the project name. > The same holds for recordmydesktop. OK, got it. > For randomjungle, the tarball does not contain a space, the description does; > then it is up to us to make a decision on what the project name is. The > tarball name is always fine. > The same holds for rubber band. > > It might also be more awkward to modify names of packages that are already > there for some time. I agree, thanks for clarifying. -- Alex