unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Kost <alezost@gmail.com>
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add Red Eclipse.
Date: Wed, 04 May 2016 11:32:08 +0300	[thread overview]
Message-ID: <87inyugr5j.fsf@gmail.com> (raw)
In-Reply-To: <20160503192317.GA5737@solar> (Andreas Enge's message of "Tue, 3 May 2016 21:23:17 +0200")

Andreas Enge (2016-05-03 22:23 +0300) wrote:

> On Tue, May 03, 2016 at 10:08:52PM +0300, Alex Kost wrote:
>> Only the package name is renamed here.  I think it would be more
>> consistent to rename the variable as well.
>
> My apologies, indeed. I will push an additional patch.

I see, thanks!

> On Tue, May 03, 2016 at 10:09:40PM +0300, Alex Kost wrote:
>> Probably; you are the master of guidelines, so I trust your judge :-)
>> OTOH we also have such packages as 'accountsservice', 'recordmydesktop',
>> 'randomjungle', 'rubberband' and others.  Should they also be renamed to
>> 'accounts-service', 'record-my-desktop', 'random-jungle', 'rubber-band',
>
> It depends; I just noticed for red-eclipse since you brought up the question.
> Now I just checked accountsservice:
>               (uri (string-append "https://www.freedesktop.org/software/"
>                                   name "/" name "-" version ".tar.xz"))
>     (description
>      "The AccountService project provides a set of D-Bus interfaces for querying
> It looks as if this should remain accountservice, since there is no space
> in the project name.
> The same holds for recordmydesktop.

OK, got it.

> For randomjungle, the tarball does not contain a space, the description does;
> then it is up to us to make a decision on what the project name is. The
> tarball name is always fine.
> The same holds for rubber band.
>
> It might also be more awkward to modify names of packages that are already
> there for some time.

I agree, thanks for clarifying.

-- 
Alex

  reply	other threads:[~2016-05-04  8:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-23  6:20 [PATCH] gnu: Add Red Eclipse Kei Yamashita
2016-04-23  7:18 ` Florian Paul Schmidt
2016-04-23 11:46   ` Kei Yamashita
2016-04-26 10:22     ` Alex Kost
2016-04-27 12:14       ` Ludovic Courtès
2016-04-28 15:52         ` Alex Kost
2016-05-02 10:38       ` Andreas Enge
2016-05-03 16:10         ` Kei Yamashita
2016-05-03 17:54           ` Andreas Enge
2016-05-03 19:08           ` Alex Kost
2016-05-03 19:23             ` Andreas Enge
2016-05-04  8:32               ` Alex Kost [this message]
2016-05-03 19:09         ` Alex Kost
2016-05-03 19:24           ` Albin
2016-05-03 19:29             ` Andreas Enge
2016-05-04  8:27             ` Alex Kost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87inyugr5j.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).