From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH ?] gnu: Add dash. Date: Fri, 29 Jul 2016 14:44:27 +0000 Message-ID: <87invoijw4.fsf@we.make.ritual.n0.is> References: <20160728020337.29026-1-me@tobias.gr> <87twfahqzz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT91l-0006E8-Fx for guix-devel@gnu.org; Fri, 29 Jul 2016 10:44:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bT91j-0007Ul-Dg for guix-devel@gnu.org; Fri, 29 Jul 2016 10:44:40 -0400 In-Reply-To: <87twfahqzz.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice Cc: guix-devel@gnu.org Ludovic Courtès writes: > Hi! > > Tobias Geerinckx-Rice skribis: > >> * gnu/packages/dash.shm: New file. >> --- >> >> Guix! >> >> IMO this belongs in a (new) shell.scm with fish, tcsh and zsh. >> Maybe bash, too. On the other hand: >> >> Certain shells might have an 'ecosystem' of 'packages', such as >> bash-completion in bash.scm, that might justify leaving them in >> their own file. I'm thinking specifically of zsh here. >> >> I'd suggest merging them all and splitting out if and when needed, >> but prefer to ask the wisdom of the list before doing that tedious >> deed. > > I would keep Bash separate, but I agree it’s a good idea to merge the > other ones in one module. > > If you want, you could do that and then add Dash to that file? > > [...] > >> + (home-page "http://gondor.apana.org.au/~herbert/dash") >> + (synopsis "POSIX-compliant shell optimised for size") >> + (description >> + "dash is a POSIX-compliant @command{/bin/sh} implementation that aims to be >> +as small as possible, often without sacrificing speed. It is significantly >> +faster than the GNU Bourne-Again Shell (@command{bash}) at most tasks. dash is >> +a direct descendant of NetBSD's Almquist Shell (@command{ash}).") >> + (license (list bsd-3 >> + gpl2+)))) ; mksignames.c > > I’d tend to remove “significantly” :-), but otherwise LGTM, thanks! I second this. Significantly faster is subjectiv as long as we do not provide some side by side benchmark results etc. > Ludo’. > -- ♥Ⓐ ng0 Current Keys: https://we.make.ritual.n0.is/ng0.txt For non-prism friendly talk find me on http://www.psyced.org