From: ng0 <ng0@we.make.ritual.n0.is>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH]: gnu: gnurl: Update to 7.50.1.
Date: Fri, 05 Aug 2016 18:19:59 +0000 [thread overview]
Message-ID: <87invfxels.fsf@we.make.ritual.n0.is> (raw)
In-Reply-To: <87eg636vvq.fsf@we.make.ritual.n0.is>
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]
ng0 <ng0@we.make.ritual.n0.is> writes:
> Leo Famulari <leo@famulari.name> writes:
>
>> On Fri, Aug 05, 2016 at 02:57:10PM +0000, ng0 wrote:
>>> From 81f605a551a3cfcfe48fae27fd7aa5d9affa4bd2 Mon Sep 17 00:00:00 2001
>>> From: ng0 <ng0@we.make.ritual.n0.is>
>>> Date: Fri, 5 Aug 2016 14:44:38 +0000
>>> Subject: [PATCH] gnu: gnurl: Update to 7.50.1.
>>>
>>> * gnu/packages/gnunet.scm (gnurl): Update to 7.50.1.
>>> [configure-flags]: Configure with --disable-smb.
>>> Disable test1139.
>>
>> Can you add a comment explaining why test1139 is disabled? Just saying
>> that it won't work doesn't tell those reading the package why it is
>> disabled.
>
> My assumption: files or lines of code are searched which will not exist
> in gnurl. If this is not just us (sadly in Gentoo i have test/checks
> disabled for this package), I will fix this upstream.
> If your perl knowledge is better look at the failing test yourself. This
> is my best judgment with the little perl knowledge I have.
> It was just ruling out what could cause the test failure.
Is this okay?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-gnurl-Update-to-7.50.1.patch --]
[-- Type: text/x-patch, Size: 2634 bytes --]
From 8b99ce31e269334aa339af27c3e78577f73052ce Mon Sep 17 00:00:00 2001
From: ng0 <ng0@we.make.ritual.n0.is>
Date: Fri, 5 Aug 2016 14:44:38 +0000
Subject: [PATCH] gnu: gnurl: Update to 7.50.1.
* gnu/packages/gnunet.scm (gnurl): Update to 7.50.1.
[configure-flags]: Configure with --disable-smb.
Disable test1139.
---
gnu/packages/gnunet.scm | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
index 4d888bd..36aa8c0 100644
--- a/gnu/packages/gnunet.scm
+++ b/gnu/packages/gnunet.scm
@@ -153,7 +153,7 @@ and support for SSL3 and TLS.")
(define-public gnurl
(package
(name "gnurl")
- (version "7.48.0")
+ (version "7.50.1")
(source (origin
(method url-fetch)
(uri (let ((version-with-underscores
@@ -162,7 +162,7 @@ and support for SSL3 and TLS.")
name "-" version-with-underscores ".tar.bz2")))
(sha256
(base32
- "14gch4rdibrc8qs4mijsczxvl45dsclf234g17dk6c8nc2s4bm0a"))))
+ "0irb8df3lqd9w1pb627q260hn448vbkh0sn4l6p6jh0q8lqscv84"))))
(build-system gnu-build-system)
(inputs `(("gnutls" ,gnutls)
("libidn" ,libidn)
@@ -183,17 +183,24 @@ and support for SSL3 and TLS.")
"--disable-ldap" "--disable-rtsp" "--disable-dict"
"--disable-telnet" "--disable-tftp" "--disable-pop3"
"--disable-imap" "--disable-smtp" "--disable-gopher"
- "--disable-file" "--disable-ftp")
+ "--disable-file" "--disable-ftp" "--disable-smb")
#:test-target "test"
#:parallel-tests? #f
- ;; We have to patch runtests.pl in tests/ directory
#:phases
+ ;; We have to patch runtests.pl in tests/ directory
(alist-cons-before
'check 'patch-runtests
(lambda _
(substitute* "tests/runtests.pl"
- (("/bin/sh") (which "sh"))))
- %standard-phases)))
+ (("/bin/sh") (which "sh"))))
+ ;; This test is disabled because of some reduction in code gnurl
+ ;; implies, it can not succeed when some functions it expects are
+ ;; not built.
+ (alist-cons-before
+ 'check 'delete-failing-test1139
+ (lambda _
+ (delete-file "tests/data/test1139"))
+ %standard-phases))))
(synopsis "Microfork of cURL with support for the HTTP/HTTPS/GnuTLS subset of cURL")
(description
"Gnurl is a microfork of cURL, a command line tool for transferring data
--
2.9.2
[-- Attachment #3: Type: text/plain, Size: 130 bytes --]
--
♥Ⓐ ng0
Current Keys: https://we.make.ritual.n0.is/ng0.txt
For non-prism friendly talk find me on http://www.psyced.org
next prev parent reply other threads:[~2016-08-05 18:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 14:52 [PATCH]: gnu: gnurl: Update to 7.50.1 ng0
2016-08-05 14:57 ` ng0
2016-08-05 15:49 ` Leo Famulari
2016-08-05 16:08 ` ng0
2016-08-05 18:19 ` ng0 [this message]
2016-08-14 9:18 ` ng0
2016-08-15 17:53 ` Leo Famulari
2016-08-15 23:24 ` ng0
2016-08-16 0:05 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87invfxels.fsf@we.make.ritual.n0.is \
--to=ng0@we.make.ritual.n0.is \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).