From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.
Date: Tue, 16 Aug 2016 23:15:07 +0300
Message-ID: <87inv0ii7o.fsf@gmail.com>
References: <20160816183938.22794-1-david@craven.ch>
	<20160816183938.22794-14-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46944)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bZklV-0001Jb-56
	for guix-devel@gnu.org; Tue, 16 Aug 2016 16:15:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bZklQ-0003GQ-4f
	for guix-devel@gnu.org; Tue, 16 Aug 2016 16:15:12 -0400
Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:34969)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1bZklP-0003FN-U4
	for guix-devel@gnu.org; Tue, 16 Aug 2016 16:15:08 -0400
Received: by mail-wm0-x242.google.com with SMTP id i5so18260769wmg.2
	for <guix-devel@gnu.org>; Tue, 16 Aug 2016 13:15:07 -0700 (PDT)
In-Reply-To: <20160816183938.22794-14-david@craven.ch> (David Craven's message
	of "Tue, 16 Aug 2016 20:39:28 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven (2016-08-16 21:39 +0300) wrote:

> * gnu/packages/gstreamer.scm (define-module): Import guix licenses with #=
:prefix
>   license:.
>   (orc): Likewise.
>   (gstreamer): Likewise.
>   (gst-plugins-base): Likewise.
>   (gst-plugins-good): Likewise.
>   (gst-plugins-bad): Likewise.
>   (gst-plugins-ugly): Likewise.
>   (gst-libav): Likewise.
>   (python-gst): Likewise.
  ^^
Please remove the leading spaces before "(...): Likewise."

I like this patch.  However in general (a question for Guix people): is
there a reason to use #:select for licenses?  Or would it be better to
use #:prefix everywhere?  If the latter (my preference), I think it
would be good to make this "#:select"=E2=86=92"#:prefix" change in a single
patch instead of making separate patches for different modules.

--=20
Alex