From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: pre-release [PATCH] git-service [v2] Date: Sat, 27 Aug 2016 23:09:16 +0300 Message-ID: <87inumdleb.fsf@gmail.com> References: <87zipsgm8g.fsf@we.make.ritual.n0.is> <87r3b33ls5.fsf@elephly.net> <87d1mhxzmu.fsf_-_@we.make.ritual.n0.is> <878tx4k2pb.fsf@we.make.ritual.n0.is> <87vaz7cnbs.fsf@we.make.ritual.n0.is> <87fupxcjs2.fsf@gmail.com> <87r39dgold.fsf@we.make.ritual.n0.is> <87fupsf81h.fsf@gmail.com> <87mvjykypr.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdjuu-0005Jf-U0 for guix-devel@gnu.org; Sat, 27 Aug 2016 16:09:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdjuo-000371-Se for guix-devel@gnu.org; Sat, 27 Aug 2016 16:09:23 -0400 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:35805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdjuo-00036x-Kj for guix-devel@gnu.org; Sat, 27 Aug 2016 16:09:18 -0400 Received: by mail-lf0-x242.google.com with SMTP id l89so5302307lfi.2 for ; Sat, 27 Aug 2016 13:09:18 -0700 (PDT) In-Reply-To: <87mvjykypr.fsf@we.make.ritual.n0.is> (ng0@we.make.ritual.n0.is's message of "Sat, 27 Aug 2016 15:39:44 +0000") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel ng0 (2016-08-27 18:39 +0300) wrote: [...] > (eval-when (expand load eval) (set! %load-path (cons "/gnu/store/8s6z5k9nfp3fyfj39vq6js8sfhxkn0y6-module-import" %load-path)) > (set! %load-compiled-path (cons "/gnu/store/lc0bj2nlmdgyqkkpd008hcnrpl068yr8-module-import-compiled" > %load-compiled-path)))(begin (use-modules (shepherd service) (oop goops) > (guix build utils) (guix build syscalls)) (make #:docstring > (quote "Git daemon server for git repositories") #:provides (quote > (git)) #:requires (quote (networking syslogd)) #:respawn? (quote #t) > #:start (make-forkexec-constructor (list (string-append "/gnu/store/f6b2a4ic4lzjv48s1w0kn6m5mxkj0qs4-git-2.9.3" "/bin/git") > "daemon" "--syslog" "--informative-errors" "--port=" "9418" "--base-path=" "/var/git/repositories")) #:stop (make-kill-destructor))) > ^______^ ^_____________^ > those two should be > combined, same for the > two afterwards? Indeed! See how useful it is to look at the result .scm file :-) You can be assured that the above thing doesn't work by running something like this in a guile REPL: (system* "git" "daemon" "--port=" "9418" "--base-path=/tmp/git-daemon-dir") while this works (assuming that "/tmp/git-daemon-dir" exists): (system* "git" "daemon" "--port=9418" "--base-path=/tmp/git-daemon-dir") So you need to 'string-append' the port and base-path as you did for the git command. (I didn't try the service, so I don't know if there are other problems, but you are getting closer, keep going!) -- Alex