From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH] gnu: Add mcelog. Date: Wed, 14 Sep 2016 20:32:10 +0100 Message-ID: <87intyb7lx.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> References: <1473859239-8101-1-git-send-email-me@tobias.gr> <8737l2d282.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <87vaxybjac.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkFv2-0007HJ-ID for guix-devel@gnu.org; Wed, 14 Sep 2016 15:32:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkFuw-0003kF-Rh for guix-devel@gnu.org; Wed, 14 Sep 2016 15:32:27 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:51403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkFuu-0003ig-Dr for guix-devel@gnu.org; Wed, 14 Sep 2016 15:32:22 -0400 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Tobias Geerinckx-Rice , guix-devel@gnu.org Tobias Geerinckx-Rice writes: > Marius, > > On 14/09/16 17:19, Marius Bakke wrote: >> Another thing, I think the snippet should be moved to a phase, as AFAIK >> origin snippets should be reserved for removing unwanted files, or for >> reproducibility. > > Not if we use your suggested snapshot tarball, which rightly lack a .git > directory. There is no way for the build system to divine the version > number at build time with =E2=80=98git describe=E2=80=99. > > Unpatched mcelog, manually built from =E2=80=98guix download=E2=80=99ed s= ources, would > report its version as =E2=80=98unknown=E2=80=99. With this snippet, it ju= st works. Yes, I was mostly echoing Leos sentiment from this post: https://lists.gnu.org/archive/html/guix-devel/2016-08/msg00937.html I don't think reporting "unknown" as a version is a critical bug, but don't have any strong opinions either way. It seems like the manual could use some clarification on its use, though. Cheers, Marius