[PATCH] gnu: Add gnome-calculator.

[PATCH] gnu: Add gnome-calculator.

[rennes]

[-- Attachment #1: Type: text/plain, Size: 84 bytes --]

This patch is a calculator for the GNOME desktop.

Built, linted and tested.

Thanks

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-gnome-calculator.patch --]
[-- Type: text/x-diff; name=0001-gnu-Add-gnome-calculator.patch, Size: 2969 bytes --]

From 1b8ce35fac1705575e9326e86aac9bdd357baa68 Mon Sep 17 00:00:00 2001
From: Rene Saavedra <rennes@openmailbox.org>
Date: Thu, 22 Sep 2016 18:47:05 -0500
Subject: [PATCH] gnu: Add gnome-calculator.

	* gnu/packages/gnome-calculator.scm (gnome-calculator): New variable.

---
 gnu/packages/gnome-calculator.scm | 59 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)
 create mode 100644 gnu/packages/gnome-calculator.scm

diff --git a/gnu/packages/gnome-calculator.scm b/gnu/packages/gnome-calculator.scm
new file mode 100644
index 0000000..36a4160
--- /dev/null
+++ b/gnu/packages/gnome-calculator.scm
@@ -0,0 +1,59 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages gnome-calculator)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix build-system glib-or-gtk)
+  #:use-module (guix download)
+  #:use-module (guix packages)
+  #:use-module (guix utils)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages gnome)
+  #:use-module (gnu packages gtk)
+  #:use-module (gnu packages multiprecision)
+  #:use-module (gnu packages pkg-config))
+
+(define-public gnome-calculator
+  (package
+    (name "gnome-calculator")
+    (version "3.20.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://gnome/sources/" name "/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "1yx86kyd54y3k3b6rmdazvmpxzl0zn791zr1q87zjc5228mc3w9a"))))
+    (build-system glib-or-gtk-build-system)
+    (native-inputs
+     `(("intltool" ,intltool)
+       ("itstool" ,itstool)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("glib" ,glib) ; for glib-compile-schemas, gio-2.0.
+       ("gtksourceview" ,gtksourceview)
+       ("libsoup" ,libsoup)
+       ("mpfr" ,mpfr)))
+    (home-page "https://wiki.gnome.org/Apps/Calculator")
+    (synopsis "Desktop calculator")
+    (description
+     "Calculator is an application that solves mathematical equations and
+is suitable as a default application in a Desktop environment.")
+    (license license:gpl3)))
-- 
2.6.3

Re: [PATCH] gnu: Add gnome-calculator.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

rennes@openmailbox.org writes:

> This patch is a calculator for the GNOME desktop.
>
> Built, linted and tested.
>
> Thanks

This is a good patch! The only change I recommend is moving the
defintion to gnome.scm.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: [PATCH] gnu: Add gnome-calculator.

[rennes]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

On Thu, 2016-09-22 at 21:23 -0400, Kei Kebreau wrote:
> 
> This is a good patch! The only change I recommend is moving the
> defintion to gnome.scm.

I update the patch,
 * Create the definition in gnome.scm file.
 * Move 'glib' to native-inputs.
 * Delete Copyright duplicate for 
   ';;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>'

Thank you

[-- Attachment #2: 0001-gnu-Add-gnome-calculator.patch --]
[-- Type: text/x-patch, Size: 2586 bytes --]

From af8eed82a79808a8bc12d6b45b3e4281854ab2c9 Mon Sep 17 00:00:00 2001
From: Rene Saavedra <rennes@openmailbox.org>
Date: Fri, 23 Sep 2016 07:53:09 -0500
Subject: [PATCH] gnu: Add gnome-calculator.

	* gnu/packages/gnome.scm (gnome-calculator): New variable.

---
 gnu/packages/gnome.scm | 32 +++++++++++++++++++++++++++++++-
 1 file changed, 31 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 01736e9..e4ff0ef 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -14,7 +14,6 @@
 ;;; Copyright © 2015, 2016 Efraim Flashner <efraim@flashner.co.il>
 ;;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>
 ;;; Copyright © 2016 Jochem Raat <jchmrt@riseup.net>
-;;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>
 ;;; Copyright © 2016 Kei Kebreau <kei@openmailbox.org>
 ;;; Copyright © 2016 Jan Nieuwenhuizen <janneke@gnu.org>
 ;;; Copyright © 2016 Roel Janssen <roel@gnu.org>
@@ -110,6 +109,7 @@
   #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages mail)
   #:use-module (gnu packages mit-krb5)
+  #:use-module (gnu packages multiprecision)
   #:use-module (gnu packages backup)
   #:use-module (gnu packages nettle)
   #:use-module (gnu packages ncurses)
@@ -5501,3 +5501,33 @@ write this kind of application, by providing a base class, taking care of all
 the IPC machinery needed to send messages to a running instance, and also
 handling the startup notification side.")
     (license license:lgpl2.1+)))
+
+(define-public gnome-calculator
+  (package
+    (name "gnome-calculator")
+    (version "3.20.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://gnome/sources/" name "/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "1yx86kyd54y3k3b6rmdazvmpxzl0zn791zr1q87zjc5228mc3w9a"))))
+    (build-system glib-or-gtk-build-system)
+    (native-inputs
+     `(("glib:bin" ,glib "bin") ; for glib-compile-schemas, gio-2.0.
+       ("intltool" ,intltool)
+       ("itstool" ,itstool)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("gtksourceview" ,gtksourceview)
+       ("libsoup" ,libsoup)
+       ("mpfr" ,mpfr)))
+    (home-page "https://wiki.gnome.org/Apps/Calculator")
+    (synopsis "Desktop calculator")
+    (description
+     "Calculator is an application that solves mathematical equations and
+is suitable as a default application in a Desktop environment.")
+    (license license:gpl3)))
-- 
2.6.3

Re: [PATCH] gnu: Add gnome-calculator.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

rennes <rennes@openmailbox.org> writes:

> On Thu, 2016-09-22 at 21:23 -0400, Kei Kebreau wrote:
>> 
>> This is a good patch! The only change I recommend is moving the
>> defintion to gnome.scm.
>
> I update the patch,
>  * Create the definition in gnome.scm file.
>  * Move 'glib' to native-inputs.
>  * Delete Copyright duplicate for 
>    ';;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>'
>
> Thank you

Looks good and works well.

Does somebody want to commit this to master?
I'd do it myself, but I'm unfamiliar with the process of commiting
someone else's code and I don't want to break anything.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: [PATCH] gnu: Add gnome-calculator.

[Ludovic Courtès]

Hello,

Kei Kebreau <kei@openmailbox.org> skribis:

> rennes <rennes@openmailbox.org> writes:
>
>> On Thu, 2016-09-22 at 21:23 -0400, Kei Kebreau wrote:
>>> 
>>> This is a good patch! The only change I recommend is moving the
>>> defintion to gnome.scm.
>>
>> I update the patch,
>>  * Create the definition in gnome.scm file.
>>  * Move 'glib' to native-inputs.
>>  * Delete Copyright duplicate for 
>>    ';;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>'
>>
>> Thank you
>
> Looks good and works well.
>
> Does somebody want to commit this to master?
> I'd do it myself, but I'm unfamiliar with the process of commiting
> someone else's code and I don't want to break anything.

It’s a good occasion to try—we need more reviewers!  :-)

The process is essentially to pipe the patch (which includes the commit
log and Subject: line) through “git am -s”.

If that applies fine, just run ‘guix lint the-package’ and ideally ‘guix
build --rounds=2 the-package’ to catch any issues.

If nothing comes up, just push!

If minor issues (typos, synopsis, etc.) come up, you might commit them
on behalf of the author, or ask them what they prefer.

Could you try and report back?  :-)

Thanks Kei & rennes!

Ludo’.

Re: [PATCH] gnu: Add gnome-calculator.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 1564 bytes --]

ludo@gnu.org (Ludovic Courtès) writes:

> Hello,
>
> Kei Kebreau <kei@openmailbox.org> skribis:
>
>> rennes <rennes@openmailbox.org> writes:
>>
>>> On Thu, 2016-09-22 at 21:23 -0400, Kei Kebreau wrote:
>>>> 
>>>> This is a good patch! The only change I recommend is moving the
>>>> defintion to gnome.scm.
>>>
>>> I update the patch,
>>>  * Create the definition in gnome.scm file.
>>>  * Move 'glib' to native-inputs.
>>>  * Delete Copyright duplicate for 
>>>    ';;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>'
>>>
>>> Thank you
>>
>> Looks good and works well.
>>
>> Does somebody want to commit this to master?
>> I'd do it myself, but I'm unfamiliar with the process of commiting
>> someone else's code and I don't want to break anything.
>
> It’s a good occasion to try—we need more reviewers!  :-)
>
> The process is essentially to pipe the patch (which includes the commit
> log and Subject: line) through “git am -s”.
>
> If that applies fine, just run ‘guix lint the-package’ and ideally ‘guix
> build --rounds=2 the-package’ to catch any issues.
>
> If nothing comes up, just push!
>
> If minor issues (typos, synopsis, etc.) come up, you might commit them
> on behalf of the author, or ask them what they prefer.
>
> Could you try and report back?  :-)
>
> Thanks Kei & rennes!
>
> Ludo’.

I've already pushed it! I guess my last message only went back to
Leo. Thank you and Leo for your help. :-)

rennes, everything looked good. Thanks for your contribution!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: [PATCH] gnu: Add gnome-calculator.

[Ludovic Courtès]

Kei Kebreau <kei@openmailbox.org> skribis:

> I've already pushed it! I guess my last message only went back to
> Leo. Thank you and Leo for your help. :-)

Well, thanks for reviewing and pushing it then!  Now you’re all set!
:-)

And thanks rennes for this patch.

Ludo’.