From: Kei Kebreau <kei@openmailbox.org>
To: rennes <rennes@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add gnome-calculator.
Date: Fri, 23 Sep 2016 12:21:09 -0400 [thread overview]
Message-ID: <87intm7fka.fsf@openmailbox.org> (raw)
In-Reply-To: <1474636075.7646.7.camel@openmailbox.org> (rennes@openmailbox.org's message of "Fri, 23 Sep 2016 08:07:55 -0500")
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
rennes <rennes@openmailbox.org> writes:
> On Thu, 2016-09-22 at 21:23 -0400, Kei Kebreau wrote:
>>
>> This is a good patch! The only change I recommend is moving the
>> defintion to gnome.scm.
>
> I update the patch,
> * Create the definition in gnome.scm file.
> * Move 'glib' to native-inputs.
> * Delete Copyright duplicate for
> ';;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>'
>
> Thank you
Looks good and works well.
Does somebody want to commit this to master?
I'd do it myself, but I'm unfamiliar with the process of commiting
someone else's code and I don't want to break anything.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-09-23 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 0:05 [PATCH] gnu: Add gnome-calculator rennes
2016-09-23 1:23 ` Kei Kebreau
2016-09-23 13:07 ` rennes
2016-09-23 16:21 ` Kei Kebreau [this message]
2016-09-24 3:18 ` Ludovic Courtès
2016-09-24 14:54 ` Kei Kebreau
2016-09-27 12:19 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87intm7fka.fsf@openmailbox.org \
--to=kei@openmailbox.org \
--cc=guix-devel@gnu.org \
--cc=rennes@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).