Re: [PATCH] gnu: Add coda.

[ludo@gnu.org (Ludovic Courtès)]

Thomas Danckaert <post@thomasdanckaert.be> skribis:

> From: ludo@gnu.org (Ludovic Courtès)
> Subject: Re: [PATCH] gnu: Add coda.
> Date: Wed, 19 Oct 2016 22:13:42 +0200
>
>>> +    (native-search-paths
>>> +     (list (search-path-specification
>>> +            (variable "PYTHONPATH")
>>> +            (files '("lib/python3.4/site-packages")))))
>>
>> Unless I’m mistaken this is not needed: this ‘native-search-paths’
>> entry
>> belongs in Python itself, not in users of Python.
>
> I used ipython to test the interface, and noticed the PYTHONPATH
> setting was missing.  That's why I added it here.  So probably this
> native-search-paths entry could/should be added to the ipython
> package?

Probably not.  I think the problem is as described in
<http://bugs.gnu.org/22138>.

>>> +    (synopsis "Common interface to various earth observation data
>>> formats")
>>> +    (description
>>> +     "The Common Data Access toolbox (CODA) provides a set of
>>> interfaces for
>>> +reading remote sensing data from earth observation data files.
>>> These
>>> +interfaces consist of command line applications, libraries,
>>> interfaces to
>>> +scientific applications (such as IDL and MATLAB), and interfaces
>>> to
>>
>> Let’s remove MATLAB; we can replace it with Octave if it’s valid.
>
> I removed IDL as well, because it's the same story as Matlab
> (proprietary scripting language for scientific applications).  I don't
> think there's an Octave interface, unless Octave can automatically use
> interfaces written for Matlab (unlikely? I have no experience with
> either).

OK.  ISTR Octave can work with “MEX files”, but I’m no expert.

> From f521132ac56e3ad6f7e6169fa1a0fcd56beb77f6 Mon Sep 17 00:00:00 2001
> From: Thomas Danckaert <thomas.danckaert@gmail.com>
> Date: Wed, 19 Oct 2016 11:44:33 +0200
> Subject: [PATCH] gnu: Add coda.
>
> * gnu/packages/maths.scm (coda): New variable.

Applied, thanks!

However I noticed that Coda bundles copies of zlib, pcre, and expat.

Could you send a patch that (1) adds those as inputs and makes sure the
bundled copies are not used (using ‘guix gc --references’ on the
result), and (2) removes the corresponding directories from the source
tree in a ‘snippet’, if possible?

Ludo’.