* [PATCH] build-system/gnu: Make libraries writable before stripping. @ 2016-11-24 16:21 Marius Bakke 2016-11-25 22:59 ` Ludovic Courtès 0 siblings, 1 reply; 3+ messages in thread From: Marius Bakke @ 2016-11-24 16:21 UTC (permalink / raw) To: guix-devel; +Cc: Marius Bakke * guix/build/gnu-build-system.scm (strip)[strip-dir]: Change mode of files before running strip-command. --- guix/build/gnu-build-system.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/guix/build/gnu-build-system.scm b/guix/build/gnu-build-system.scm index 1dfd854..59394c2 100644 --- a/guix/build/gnu-build-system.scm +++ b/guix/build/gnu-build-system.scm @@ -393,6 +393,8 @@ makefiles." (or (elf-file? file) (ar-file? file)) (or (not debug-output) (make-debug-file file)) + ;; Ensure libraries are writable. + (chmod file #o755) (zero? (apply system* strip-command (append strip-flags (list file)))) (or (not debug-output) -- 2.10.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] build-system/gnu: Make libraries writable before stripping. 2016-11-24 16:21 [PATCH] build-system/gnu: Make libraries writable before stripping Marius Bakke @ 2016-11-25 22:59 ` Ludovic Courtès 2016-11-26 8:11 ` Marius Bakke 0 siblings, 1 reply; 3+ messages in thread From: Ludovic Courtès @ 2016-11-25 22:59 UTC (permalink / raw) To: Marius Bakke; +Cc: guix-devel Marius Bakke <mbakke@fastmail.com> skribis: > * guix/build/gnu-build-system.scm (strip)[strip-dir]: Change mode of > files before running strip-command. OK for ‘core-updates’. Note that a few packages did that by hand. While you’re at it, you can adjust them. Thanks! Ludo’. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] build-system/gnu: Make libraries writable before stripping. 2016-11-25 22:59 ` Ludovic Courtès @ 2016-11-26 8:11 ` Marius Bakke 0 siblings, 0 replies; 3+ messages in thread From: Marius Bakke @ 2016-11-26 8:11 UTC (permalink / raw) To: Ludovic Courtès; +Cc: guix-devel [-- Attachment #1: Type: text/plain, Size: 447 bytes --] Ludovic Courtès <ludo@gnu.org> writes: > Marius Bakke <mbakke@fastmail.com> skribis: > >> * guix/build/gnu-build-system.scm (strip)[strip-dir]: Change mode of >> files before running strip-command. > > OK for ‘core-updates’. Cool, pushed! > Note that a few packages did that by hand. While you’re at it, you > can adjust them. That was the motivation. I will submit a patch removing most users after next master merge. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 487 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-26 8:11 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-11-24 16:21 [PATCH] build-system/gnu: Make libraries writable before stripping Marius Bakke 2016-11-25 22:59 ` Ludovic Courtès 2016-11-26 8:11 ` Marius Bakke
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).