From: Ricardo Wurmus <rekado@elephly.net>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: python-pyqt: Fix build by explicitly setting the stubsdir.
Date: Sat, 03 Dec 2016 17:12:17 +0100 [thread overview]
Message-ID: <87inr1dmam.fsf@elephly.net> (raw)
In-Reply-To: <1480698614-20481-1-git-send-email-h.goebel@crazy-compilers.com>
Hartmut Goebel <h.goebel@crazy-compilers.com> writes:
> Without this option the stub files are tried to be installed into
> the python package's site-package directory.
>
> * gnu/packages.qt.scm (python-pyqt, python2-pyqt)[arguments]: In phase
> 'configure' pass option --stubsdir.
> ---
> gnu/packages/qt.scm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
> index b442356..92c6d4b 100644
> --- a/gnu/packages/qt.scm
> +++ b/gnu/packages/qt.scm
> @@ -982,13 +982,15 @@ module provides support functions to the automatically generated code.")
> "."))
> (lib (string-append out "/lib/python"
> python-major+minor
> - "/site-packages")))
> + "/site-packages"))
> + (stubs (string-append lib "/PyQt5")))
> (zero? (system* "python" "configure.py"
> "--confirm-license"
> "--bindir" bin
> "--destdir" lib
> "--designer-plugindir" designer
> "--qml-plugindir" qml
> + "--stubsdir" stubs ; PEP 484 Type Hints stubs
> "--sipdir" sip))))))))
> (home-page "https://www.riverbankcomputing.com/software/pyqt/intro")
> (synopsis "Python bindings for Qt")
The patch looks okay to me, but I’d prefer to see your comment about why
this is needed inline above the option. “PEP 484…” doesn’t tell me
anything, whereas your description in this email was very clear.
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
http://elephly.net
next prev parent reply other threads:[~2016-12-03 16:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 17:10 [PATCH] gnu: python-pyqt: Fix build by explicitly setting the stubsdir Hartmut Goebel
2016-12-03 16:12 ` Ricardo Wurmus [this message]
2016-12-05 8:53 ` Hartmut Goebel
2016-12-05 9:12 ` [PATCH 0/3] Fixes for python-pyqt Hartmut Goebel
2016-12-05 9:12 ` [PATCH 1/3] gnu: python2-pyqt-4: Change package name to python2-pyqt Hartmut Goebel
2016-12-08 21:17 ` Efraim Flashner
2016-12-05 9:12 ` [PATCH 2/3] gnu: python-pyqt-5.5: Use non-inherited "configure" phase Hartmut Goebel
2016-12-05 12:44 ` Hartmut Goebel
2016-12-08 21:19 ` Efraim Flashner
2016-12-09 12:28 ` Hartmut Goebel
2016-12-09 12:30 ` Efraim Flashner
2016-12-09 12:54 ` Hartmut Goebel
2016-12-05 9:12 ` [PATCH 3/3 v2] gnu: python-pyqt: Fix build by explicitly setting the stubsdir Hartmut Goebel
2016-12-08 21:20 ` Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inr1dmam.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).