From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: make-bootstrap: Produce the correct
	%glibc-bootstrap-tarball for Hurd systems.
Date: Wed, 07 Dec 2016 11:50:48 +0100
Message-ID: <87inqw9fnb.fsf@gnu.org>
References: <bdbf1506-8b27-dd18-284b-ce8bc2f1c17b@gmail.com>
	<fc10f3ef-3d88-68fd-c5d0-fa1dc125f4ce@gmail.com>
	<87invs793a.fsf@gnu.org>
	<0ba62574-04a2-8b34-1816-510745a22985@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40833)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cEZoN-0004Na-Ow
	for guix-devel@gnu.org; Wed, 07 Dec 2016 05:50:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1cEZoJ-0006Qe-NU
	for guix-devel@gnu.org; Wed, 07 Dec 2016 05:50:55 -0500
In-Reply-To: <0ba62574-04a2-8b34-1816-510745a22985@gmail.com> (Manolis
	Ragkousis's message of "Wed, 7 Dec 2016 11:55:18 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: guix-devel@gnu.org

Hello Manolis!

Manolis Ragkousis <manolis837@gmail.com> skribis:

> This is an old patch which I had forgotten I hadn't pushed to
> core-updates back then.
>
> This is the updated version with your suggestions and checked that it
> works with latest core-updates.

I believe it can go to master since it does not trigger rebuilds.

> From 0e21f4484f67dfd6ed132e9e5b5934f3098c98b3 Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <manolis837@gmail.com>
> Date: Wed, 30 Nov 2016 16:49:48 +0200
> Subject: [PATCH] gnu: make-bootstrap: Produce the correct
>  %glibc-bootstrap-tarball for Hurd systems.
>
> * gnu/packages/make-bootstrap.scm (%glibc-bootstrap-tarball): Make it a p=
rocedure.
>   (%glibc-stripped): Make it a procedure and move the kernel specific par=
t from
>   here to ...
> * guix/build/make-bootstrap.scm (make-stripped-libc): ... here. New file.
> * Makefile.am (MODULES): Add it.

[...]

>         ;; `cross-libc' already returns a cross libc, so clear
>         ;; %CURRENT-TARGET-SYSTEM.
>         (parameterize ((%current-target-system #f))
> -         (cross-libc target)))))
> +         (cross-libc target )))))

Nope.  :-)

Apart from that it LGTM!

Thank you,
Ludo=E2=80=99.