From mboxrd@z Thu Jan  1 00:00:00 1970
From: iyzsong@member.fsf.org (=?utf-8?B?5a6L5paH5q2m?=)
Subject: Re: [PATCH 2/2] services: network-manager: Use record for
	configuration.
Date: Fri, 20 Jan 2017 21:48:10 +0800
Message-ID: <87inp9kfl1.fsf@member.fsf.org>
References: <20170119065539.988-1-mail@cbaines.net>
	<20170119065539.988-2-mail@cbaines.net>
	<87ziinb7fr.fsf@member.fsf.org> <87shoexgjv.fsf@cbaines.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58690)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1cUZeK-0005qI-IX
	for guix-devel@gnu.org; Fri, 20 Jan 2017 08:54:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@openmailbox.org>) id 1cUZeH-0001un-Gj
	for guix-devel@gnu.org; Fri, 20 Jan 2017 08:54:40 -0500
Received: from lb1.openmailbox.org ([5.79.108.160]:44754)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <iyzsong@openmailbox.org>)
	id 1cUZeH-0001tv-At
	for guix-devel@gnu.org; Fri, 20 Jan 2017 08:54:37 -0500
In-Reply-To: <87shoexgjv.fsf@cbaines.net> (Christopher Baines's message of
	"Fri, 20 Jan 2017 08:48:52 +0000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: guix-devel@gnu.org

Christopher Baines <mail@cbaines.net> writes:

> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@member.fsf.org> writes:
>
>> Christopher Baines <mail@cbaines.net> writes:
>>
>>> * gnu/services/network-manager.scm (<network-manager-configuration>): N=
ew
>>> record type.
>>> (network-manager-shpeherd-service): Change to use the
>>> network-manager-configuration record, rather than a package.  Generate a
>>> simple configuration file from the network-manager-configuration record.
>>> (network-manager-service-type): Update extensions to take the
>>> network-manager-configuration rather than a package.
>>> ---
>>>  gnu/services/networking.scm | 77 +++++++++++++++++++++++++++++--------=
--------
>>>  1 file changed, 50 insertions(+), 27 deletions(-)
>>
>> Thanks, could you mention the remove of 'network-manager-service' in the
>> changelog and update the 'Network Manager' section of manual?
>
> Thanks for your review. I've sent an updated patch now, which includes
> the removal of network-manager-service in the commit message (I'm hoping
> that is what you meant by changelog), and manual updates.

Applied, thank you!