From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: [PATCH 2/5] gnu: Add seabios. Date: Fri, 10 Feb 2017 00:55:36 +0100 Message-ID: <87inoisyvb.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <20170209190450.29458-1-david@craven.ch> <20170209190450.29458-5-david@craven.ch> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cbyYy-0004p6-V7 for guix-devel@gnu.org; Thu, 09 Feb 2017 18:55:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cbyYu-00070i-QM for guix-devel@gnu.org; Thu, 09 Feb 2017 18:55:44 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:48680) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cbyYu-0006zA-Du for guix-devel@gnu.org; Thu, 09 Feb 2017 18:55:40 -0500 In-Reply-To: <20170209190450.29458-5-david@craven.ch> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: David Craven , guix-devel@gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable David Craven writes: > * gnu/packages/grub.scm (seabios): New variable. I would place this in "firmware.scm". > --- > gnu/packages/grub.scm | 38 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/gnu/packages/grub.scm b/gnu/packages/grub.scm > index 292d35373..a775e213c 100644 > --- a/gnu/packages/grub.scm > +++ b/gnu/packages/grub.scm > @@ -33,6 +33,7 @@ > #:use-module (gnu packages gettext) > #:use-module (gnu packages fontutils) > #:use-module (gnu packages linux) > + #:use-module (gnu packages python) > #:use-module (gnu packages qemu) > #:use-module (gnu packages man) > #:use-module (gnu packages texinfo) > @@ -150,3 +151,40 @@ menu to select one of the installed operating system= s.") > (string-append (assoc-ref inputs "efibootmgr") > "/sbin/efibootmgr"))) > #t))))))))) > + > +(define-public seabios > + (package > + (name "seabios") > + (version "1.10.1") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://code.coreboot.org/p/seabios/d= ownloads/get/" > + "seabios-" version ".tar.gz")) > + (sha256 > + (base32 > + "1jyjl719drnl1v0gf0l5q6qjjmkyqcqkka6s28dfdi0yqsxdsqsh"))= )) > + (build-system gnu-build-system) > + (native-inputs > + `(("python-2" ,python-2))) > + (arguments > + `(#:tests? #f ; No check target. > + #:phases > + (modify-phases %standard-phases > + (replace 'configure > + (lambda* (#:key inputs #:allow-other-keys) > + (let ((gcc (assoc-ref inputs "gcc"))) > + (setenv "CC" (string-append gcc "/bin/gcc"))) Does it need the full path, or would simply "gcc" be enough here? > + #t)) > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (fmw (string-append out "/share/firmware"))) > + (mkdir-p fmw) > + (copy-file "out/bios.bin" (string-append fmw "/bios.bin" #t)))))))) > + (home-page "https://www.seabios.org/SeaBIOS") > + (synopsis "x86 BIOS implementation") > + (description "SeaBIOS is an open source implementation of a 16bit x8= 6 BIOS. > +SeaBIOS can run in an emulator or it can run natively on X86 hardware wi= th the > +use of coreboot.") > + ;; Dual licensed. > + (license (list license:gpl3+ license:lgpl3+)))) The Debian copyright file for this package mentions two other licenses in use. They should probably be listed too. Otherwise LGTM. Thank you! > --=20 > 2.11.0 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlidAXkACgkQoqBt8qM6 VPoeFwf+OkdvqokidzWBlQYYb/u8kenVI991QSPPfj+i++9iauo09mJwyIulUu8q gxh3cfCVCzGB5FkJXVFWLaHe7N+QkcP2989NaOBsAozwGiBhBt1Zsi7NnyCxatBZ UAW2pqUZcZwwDeNSIXWpK5m77TJydxkuWyEipB+J165TsQvYyta56T3LiGH9TgCO SUmmaTTCF5km64HSob4WL8DXjNa9eWYc65V7oo7Ye+gd8JeLbs4w4Gl51iWGtTbv syBK1HGz1U3hRrUk3Srdc0z46bfcbyncGsgZsuZUie2OXrUgX7b2gTojWS5tP81C Evqbn4YaLQCawqN//QiNoEVi+7rn0A== =GzQP -----END PGP SIGNATURE----- --=-=-=--