From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Meyer Subject: Re: [PATCH] qjackctl Date: Mon, 03 Apr 2017 20:15:20 +0200 Message-ID: <87inmlz7bb.fsf@ofosos.org> References: <8760isbei6.fsf@ofosos.org> <87a87xsx7q.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cv6Vl-0001SQ-QJ for guix-devel@gnu.org; Mon, 03 Apr 2017 14:15:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cv6Vi-0002Cg-IS for guix-devel@gnu.org; Mon, 03 Apr 2017 14:15:29 -0400 In-Reply-To: <87a87xsx7q.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 03 Apr 2017 10:37:45 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> "LC" =3D=3D Ludovic Court=C3=A8s writes: LC> Could you try to come up with a ChangeLog-style commit message LC> that follows our convention? You can see =E2=80=98git log=E2=80=99= for examples LC> of what to type, and LC> . I think I fixed that, I looked up the GNU guidelines and included the following line: * gnu/packages/audio.scm (qjackctl): Add new package. LC> The propose synopsis is too long, and the original string was OK LC> as a synopsis; see LC> . Got confused with the `synopsis' and `description'. LC> Could you send an updated patch for qjackctl? Make sure to run LC> ./pre-inst-env guix lint qjackctl LC> before and to address any issues it reports. Lint reports no errors. Cheers, Mark --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-2017-04-03-Mark-Meyer-mark-ofosos.org.patch Content-Description: qjackctl patch >From 22b1c2a835c818d6e9d502260ddfa4de11a8a88a Mon Sep 17 00:00:00 2001 From: Mark Meyer Date: Mon, 3 Apr 2017 19:58:49 +0200 Subject: [PATCH] 2017-04-03 Mark Meyer * gnu/packages/audio.scm (qjackctl): Add new package. --- gnu/packages/audio.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 2b11a32ca..b835b44dc 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -1783,6 +1783,36 @@ buffers, and audio capture.") and ALSA.") (license license:gpl3+))) +(define-public qjackctl + (package + (name "qjackctl") + (version "0.4.4") + (source (origin + (method url-fetch) + (uri + (string-append + "https://downloads.sourceforge.net/project/qjackctl/qjackctl/" + version "/qjackctl-" version ".tar.gz")) + (sha256 + (base32 + "19bbljb3iz5ss4s5fmra1dxabg2fnp61sa51d63zsm56xkvv47ak")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f)) ; no check target + + (inputs + `(("jack-2" ,jack-2) + ("qt" ,qt))) + (native-inputs + `(("pkg-config" ,pkg-config) + ("qttools" ,qttools))) + (home-page "https://qjackctl.sourceforge.io/") + (synopsis "Jack server control application") + (description "Control a Jack server. Allows you to plug various sources +into various outputs and to start, stop and configure jackd") + (license license:gpl2+))) + + (define-public raul (package (name "raul") -- 2.12.1 --=-=-=--