[PATCH] qjackctl

[PATCH] qjackctl

[Mark Meyer]

[-- Attachment #1: Type: text/plain, Size: 64 bytes --]

Hi list,
this is a patch to package up qjackctl.

Cheers, Mark


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch to add qjackctl --]
[-- Type: text/x-patch, Size: 1413 bytes --]

From 93bdb3c4f6b8d74584ec29ea4f6733c373c44ab2 Mon Sep 17 00:00:00 2001
From: Mark Meyer <mark@ofosos.org>
Date: Wed, 29 Mar 2017 10:35:46 +0200
Subject: [PATCH 1/2] Add qjackctl to the audio packages.

---
 gnu/packages/audio.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 2b11a32ca..d1f360d3d 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -1783,6 +1783,32 @@ buffers, and audio capture.")
 and ALSA.")
     (license license:gpl3+)))
 
+(define-public qjackctl
+  (package
+    (name "qjackctl")
+    (version "0.4.4")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://downloads.sourceforge.net/qjackctl/qjackctl-" version ".tar.gz"))
+              (sha256
+               (base32
+                "19bbljb3iz5ss4s5fmra1dxabg2fnp61sa51d63zsm56xkvv47ak"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f)) ; no check target
+
+    (inputs
+     `(("jack-2" ,jack-2)
+       ("qt" ,qt)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("qttools" ,qttools)))
+    (home-page "https://qtjackctl.sourceforge.io")
+    (synopsis "A Jack server control application")
+    (description "Control a Jack server")
+    (license license:gpl2+)))
+    
+  
 (define-public raul
   (package
     (name "raul")
-- 
2.12.1


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: add a proper description --]
[-- Type: text/x-patch, Size: 872 bytes --]

From 33b194b92c563c370a41cffa485594fb321f2e14 Mon Sep 17 00:00:00 2001
From: Mark Meyer <mark@ofosos.org>
Date: Wed, 29 Mar 2017 11:41:08 +0200
Subject: [PATCH 2/2] Add a proper synopsis

---
 gnu/packages/audio.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index d1f360d3d..7ebf68ee3 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -1804,7 +1804,7 @@ and ALSA.")
      `(("pkg-config" ,pkg-config)
        ("qttools" ,qttools)))
     (home-page "https://qtjackctl.sourceforge.io")
-    (synopsis "A Jack server control application")
+    (synopsis "A Jack server control application that allows you to plug various sources into various outputs and to start, stop and configure jackd")
     (description "Control a Jack server")
     (license license:gpl2+)))
     
-- 
2.12.1

Re: [PATCH] qjackctl

[Ludovic Courtès]

Hi Mark,

Thanks for the patches!

They look all right, except a couple of minor details:

Mark Meyer <mark@ofosos.org> skribis:

> From 93bdb3c4f6b8d74584ec29ea4f6733c373c44ab2 Mon Sep 17 00:00:00 2001
> From: Mark Meyer <mark@ofosos.org>
> Date: Wed, 29 Mar 2017 10:35:46 +0200
> Subject: [PATCH 1/2] Add qjackctl to the audio packages.
>
> ---
>  gnu/packages/audio.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)

Could you try to come up with a ChangeLog-style commit message that
follows our convention?  You can see ‘git log’ for examples of what to
type, and
<https://gnu.org/software/guix/manual/html_node/Submitting-Patches.html>.

Don’t worry too much about it, I can always fix it if there are small
issues, but it’s better if you give it a try.  :-)

> +    (synopsis "A Jack server control application")
> +    (description "Control a Jack server")

Please write a full description; see
<https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html>.

> From 33b194b92c563c370a41cffa485594fb321f2e14 Mon Sep 17 00:00:00 2001
> From: Mark Meyer <mark@ofosos.org>
> Date: Wed, 29 Mar 2017 11:41:08 +0200
> Subject: [PATCH 2/2] Add a proper synopsis
>
> ---
>  gnu/packages/audio.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index d1f360d3d..7ebf68ee3 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -1804,7 +1804,7 @@ and ALSA.")
>       `(("pkg-config" ,pkg-config)
>         ("qttools" ,qttools)))
>      (home-page "https://qtjackctl.sourceforge.io")
> -    (synopsis "A Jack server control application")
> +    (synopsis "A Jack server control application that allows you to plug various sources into various outputs and to start, stop and configure jackd")

The propose synopsis is too long, and the original string was OK as a
synopsis; see
<https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html>.

Could you send an updated patch for qjackctl?  Make sure to run

  ./pre-inst-env guix lint qjackctl

before and to address any issues it reports.

Thanks in advance!

Ludo’.

Re: [PATCH] qjackctl

[Mark Meyer]

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

>>>>> "LC" == Ludovic Courtès <ludo@gnu.org> writes:

    LC> Could you try to come up with a ChangeLog-style commit message
    LC> that follows our convention?  You can see ‘git log’ for examples
    LC> of what to type, and
    LC> <https://gnu.org/software/guix/manual/html_node/Submitting-Patches.html>.

I think I fixed that, I looked up the GNU guidelines and included the
following line:

* gnu/packages/audio.scm (qjackctl): Add new package.

    LC> The propose synopsis is too long, and the original string was OK
    LC> as a synopsis; see
    LC> <https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html>.

Got confused with the `synopsis' and `description'.

    LC> Could you send an updated patch for qjackctl?  Make sure to run

    LC>   ./pre-inst-env guix lint qjackctl

    LC> before and to address any issues it reports.

Lint reports no errors.

Cheers, Mark


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: qjackctl patch --]
[-- Type: text/x-patch, Size: 1640 bytes --]

From 22b1c2a835c818d6e9d502260ddfa4de11a8a88a Mon Sep 17 00:00:00 2001
From: Mark Meyer <mark@ofosos.org>
Date: Mon, 3 Apr 2017 19:58:49 +0200
Subject: [PATCH] 2017-04-03 Mark Meyer <mark@ofosos.org>

* gnu/packages/audio.scm (qjackctl): Add new package.
---
 gnu/packages/audio.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 2b11a32ca..b835b44dc 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -1783,6 +1783,36 @@ buffers, and audio capture.")
 and ALSA.")
     (license license:gpl3+)))
 
+(define-public qjackctl
+  (package
+    (name "qjackctl")
+    (version "0.4.4")
+    (source (origin
+              (method url-fetch)
+              (uri
+               (string-append
+                "https://downloads.sourceforge.net/project/qjackctl/qjackctl/"
+                version "/qjackctl-" version ".tar.gz"))
+              (sha256
+               (base32
+                "19bbljb3iz5ss4s5fmra1dxabg2fnp61sa51d63zsm56xkvv47ak"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f)) ; no check target
+
+    (inputs
+     `(("jack-2" ,jack-2)
+       ("qt" ,qt)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("qttools" ,qttools)))
+    (home-page "https://qjackctl.sourceforge.io/")
+    (synopsis "Jack server control application")
+    (description "Control a Jack server.  Allows you to plug various sources
+into various outputs and to start, stop and configure jackd")
+    (license license:gpl2+)))
+
+
 (define-public raul
   (package
     (name "raul")
-- 
2.12.1

Re: [PATCH] qjackctl

[Ludovic Courtès]

Mark Meyer <mark@ofosos.org> skribis:

> From 22b1c2a835c818d6e9d502260ddfa4de11a8a88a Mon Sep 17 00:00:00 2001
> From: Mark Meyer <mark@ofosos.org>
> Date: Mon, 3 Apr 2017 19:58:49 +0200
> Subject: [PATCH] 2017-04-03 Mark Meyer <mark@ofosos.org>
>
> * gnu/packages/audio.scm (qjackctl): Add new package.

Perfect!  I adjusted the commit log and applied, thanks!

Ludo’.