unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: ISO image available for testing!
Date: Wed, 06 Dec 2017 09:14:26 +0100	[thread overview]
Message-ID: <87indk9st9.fsf@gnu.org> (raw)
In-Reply-To: <87bmjcvft3.fsf@netris.org> (Mark H. Weaver's message of "Tue, 05 Dec 2017 19:52:08 -0500")

Hi Mark,

Mark H Weaver <mhw@netris.org> skribis:

> ludo@gnu.org (Ludovic Courtès) writes:
>> 91c9b5d01 * packages: 'package-grafts' trims native inputs.
>
> [...]
>
>> Long story short: we were flagging native inputs as potential sources of
>> grafts even though, by definition, native inputs are not referred to at
>> run time.
>
> I agree that this *should* never happen, but I see little reason for
> confidence that it never happens in actual fact.
>
> What would happen if a reference to a native-input *was* present in the
> build outputs?  The reason I ask is that, for security reasons, it's
> obviously very important to reliably avoid using ungrafted software at
> run time.
>
> I'm concerned that this recent change could cause minor
> nearly-undetectable packaging mistakes to become major security holes.

Given the examples that Tobias and Ben were quick to find, I’m afraid
you’re right and I was overconfident.  I’m reverting the change.

> One solution would be to explicitly check build outputs for references
> to native-inputs, and to force a build failure in that case.

We could do that, though I suppose a lot of packages would break.

Thanks to the quick reply,
Ludo’.

  parent reply	other threads:[~2017-12-06  8:14 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-24 13:11 What’s next? Ludovic Courtès
2017-05-24 13:23 ` Ricardo Wurmus
2017-05-27 10:01   ` Ludovic Courtès
2017-05-27 21:44     ` Ricardo Wurmus
2017-05-28 20:44       ` Ludovic Courtès
2017-05-28 21:36         ` Ricardo Wurmus
2017-05-30 15:55           ` Ludovic Courtès
2017-05-24 15:52 ` Brendan Tildesley
2017-05-27 10:04   ` Ludovic Courtès
2017-05-28 20:41     ` Maxim Cournoyer
2017-05-30 15:17       ` Ludovic Courtès
2017-06-03 21:16         ` Maxim Cournoyer
2017-05-24 16:09 ` Catonano
2017-05-24 16:25 ` Jan Nieuwenhuizen
2017-05-24 18:40   ` Adonay Felipe Nogueira
2017-05-24 19:34   ` Catonano
2017-05-24 19:56     ` Ricardo Wurmus
2017-05-30  0:09       ` myglc2
2017-05-24 21:47     ` Leo Famulari
2017-05-24 21:45   ` Leo Famulari
2017-05-25  8:11     ` What???s next? Pjotr Prins
2017-05-27 10:16       ` Ludovic Courtès
2017-05-28  7:30         ` What's next? Pjotr Prins
2017-05-28 20:48           ` Ludovic Courtès
2017-05-28 22:05             ` Roel Janssen
2017-05-30 15:19               ` Ludovic Courtès
2017-05-30 20:15                 ` Pjotr Prins
2017-05-29  2:31             ` Maxim Cournoyer
2017-05-28 20:37         ` What???s next? Maxim Cournoyer
2017-05-28 21:34           ` Ricardo Wurmus
2017-05-30 15:14           ` Ludovic Courtès
2017-05-25 14:57     ` What’s next? Chris Marusich
2017-05-25 18:32       ` Leo Famulari
2017-05-25 20:01       ` Ricardo Wurmus
2017-05-25 20:41         ` Adonay Felipe Nogueira
2017-05-27 10:13         ` Ludovic Courtès
2017-05-29 23:28           ` myglc2
2017-06-08 14:35           ` Ricardo Wurmus
2017-05-27 10:09   ` Ludovic Courtès
2017-10-04 15:12 ` Release! Ludovic Courtès
2017-10-05 19:18   ` Release! Christopher Baines
2017-10-06 13:01     ` Release! Ludovic Courtès
2017-10-09  7:25       ` Release! Christopher Baines
2017-10-09 16:25         ` Release! Ludovic Courtès
2017-10-06 18:30   ` Release! Ricardo Wurmus
2017-10-06 23:31     ` Release! David Pirotte
2017-10-07  9:18       ` Release! Hartmut Goebel
2017-10-07 12:21         ` Release! David Pirotte
2017-10-07 21:30       ` Release! Ricardo Wurmus
2017-10-08 13:08         ` Release! Hartmut Goebel
2017-10-07  4:06     ` [PATCH] DRAFT: build: Compile scheme modules in batches (was Re: Release!) Mark H Weaver
2017-10-07 19:35       ` Efraim Flashner
2017-10-08  9:19       ` Ricardo Wurmus
2017-10-08 12:03         ` Ricardo Wurmus
2017-10-08 13:26           ` Ricardo Wurmus
2017-10-09  7:38             ` Ludovic Courtès
2017-10-09 11:32               ` Ricardo Wurmus
2017-10-10  6:52                 ` Ricardo Wurmus
2017-10-09  7:42       ` Ludovic Courtès
2017-10-09  7:53     ` Release! Ludovic Courtès
2017-11-20 22:07     ` Release! Ludovic Courtès
2017-11-30 10:40     ` Release! Ludovic Courtès
2017-12-01  2:57       ` Release! Maxim Cournoyer
2017-12-01 18:30       ` Release! Leo Famulari
2017-12-01 19:32         ` Release! Ricardo Wurmus
2017-12-04  8:53           ` Release! Ludovic Courtès
2017-12-04  8:58           ` ISO image available for testing! Ludovic Courtès
2017-12-04 21:35             ` Christopher Baines
2017-12-04 22:34               ` Ludovic Courtès
2017-12-05 22:47               ` Ludovic Courtès
2017-12-06  0:52                 ` Mark H Weaver
2017-12-06  1:17                   ` Ben Woodcroft
2017-12-06  2:16                   ` native-inputs ending up as run-time references [was: ISO image available for testing!] Tobias Geerinckx-Rice
2017-12-06  3:18                     ` Leo Famulari
2017-12-06  3:48                       ` Tobias Geerinckx-Rice
2017-12-06  8:04                   ` ISO image available for testing! Mark H Weaver
2017-12-06  8:14                   ` Ludovic Courtès [this message]
2017-12-06 16:29                     ` Tobias Geerinckx-Rice
2017-12-07 20:09                 ` Christopher Baines
2017-12-07 21:19                   ` Ludovic Courtès
2017-12-04  8:52         ` Release! Ludovic Courtès
2017-12-05  2:47           ` Release! Maxim Cournoyer
  -- strict thread matches above, loose matches on Subject: below --
2017-12-05 22:05 ISO image available for testing! D4n1
2017-12-05 22:15 D4n1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87indk9st9.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).