From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: java: switch to icedtea-8 as default JDK Date: Fri, 05 Jan 2018 16:44:58 +0100 Message-ID: <87incg48ed.fsf@elephly.net> References: <87o9n3gz43.fsf@gmail.com> <20171213103248.GA12880@macbook41> <877etlo2fq.fsf@elephly.net> <87y3lzgmy1.fsf@gmail.com> <877etiz7uu.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:32988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eY9Bb-0008F9-BL for guix-devel@gnu.org; Sun, 07 Jan 2018 06:32:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eY9BY-0006kv-9E for guix-devel@gnu.org; Sun, 07 Jan 2018 06:32:19 -0500 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21075) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eY9BY-0006k2-13 for guix-devel@gnu.org; Sun, 07 Jan 2018 06:32:16 -0500 In-reply-to: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?utf-8?Q?G=C3=A1bor?= Boskovits Cc: guix-devel G=C3=A1bor Boskovits writes: > If I understand well, then the check phase in ant-build-system > runs without make-flags. > In the definition of java-asm we configure the build with make-flags, so > the build system > does not complain about missing configuration. > This configuration is still needed for the test target, so building that > fails. > > We could do two things: > 1. Patch build.xml to not perform these checks. (Then we can also remove > the make-flags all togethet) > 2. Do something, so that we can pass make-flags to check phase, maybe by > introducing test-make-flags, or something like that to > ant-build-system. You could also replace the check phase to run ant with the make-flags. --=20 Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net