unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Andy Wingo <wingo@igalia.com>
Cc: guix-devel@gnu.org
Subject: Re: question regarding substitute* and #t
Date: Thu, 25 Jan 2018 00:31:04 -0500	[thread overview]
Message-ID: <87inbq8pyf.fsf@gmail.com> (raw)
In-Reply-To: <87y3kn706z.fsf@igalia.com> (Andy Wingo's message of "Wed, 24 Jan 2018 16:20:36 +0100")

Andy Wingo <wingo@igalia.com> writes:

> On Wed 24 Jan 2018 14:28, Mark H Weaver <mhw@netris.org> writes:
>
>> Andy Wingo <wingo@igalia.com> writes:
>>
>>> On Wed 24 Jan 2018 13:06, Mark H Weaver <mhw@netris.org> writes:
>>>
>>>> +             ;; Install to the right directory
>>>> +             (substitute* '("Makefile"
>>>> +                            "Qsci/Makefile")
>>>> +               (("\\$\\(INSTALL_ROOT\\)/gnu/store/[^/]+")
>>>> +                (assoc-ref outputs "out")))
>>>> +             #t)))))
>>>
>>> I guess once we switch over all instances of "system" and "system*" to
>>> use invoke, does that mean we will also be able to remove these
>>> vestigial "#t" returns?
>>
>> After we switch to using 'invoke' everywhere, or more precisely, after
>> we arrange to never return #false from any phase or snippet, then there
>> should be one more step before removing the vestigial #true returns: we
>> should change the code that calls phases or snippets to ignore the
>> value(s) returned by those procedures.  When that is done, then the #t's
>> will truly be vestigial.  Does that make sense?
>
> Sure, makes sense.  Thanks for thinking it through with me :)
>
> Andy

Where does this `invoke' comes from? Geiser is unhelpful at finding it,
and it doesn't seem to be documented in the Guile Reference?

Thanks,

Maxim

  parent reply	other threads:[~2018-01-25  5:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180124010802.18874.3012@vcs0.savannah.gnu.org>
     [not found] ` <20180124010803.590AF2068F@vcs0.savannah.gnu.org>
2018-01-24 12:06   ` Simplifications enabled by switching to 'invoke' Mark H Weaver
2018-01-24 12:14     ` question regarding substitute* and #t (was: Simplifications enabled by switching to 'invoke') Andy Wingo
2018-01-24 13:28       ` question regarding substitute* and #t Mark H Weaver
2018-01-24 15:20         ` Andy Wingo
2018-01-24 21:09           ` Kei Kebreau
2018-01-25  5:31           ` Maxim Cournoyer [this message]
2018-01-25  7:51             ` Andy Wingo
2018-01-26  3:53               ` Maxim Cournoyer
2018-01-25  8:31         ` Arun Isaac
2018-01-25 20:02           ` Mark H Weaver
2018-01-24 14:45       ` Hartmut Goebel
2018-01-24 15:27         ` Andy Wingo
2018-01-24 22:10           ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87inbq8pyf.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=wingo@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).