From: Mark H Weaver <mhw@netris.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: 03/07: gnu: libfive: Add snippet, enable tests and remove obsolete phase.
Date: Thu, 19 Apr 2018 08:26:22 -0400 [thread overview]
Message-ID: <87in8nidqp.fsf@netris.org> (raw)
In-Reply-To: <20180419095904.D9E2D204EE@vcs0.savannah.gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22's\?\= message of "Thu, 19 Apr 2018 05:59:04 -0400 (EDT)")
Hi Ludovic,
ludo@gnu.org (Ludovic Courtès) writes:
> civodul pushed a commit to branch master
> in repository guix.
>
> commit 0818c01aefbaa7ecce5e310ec5f70886850a7f9c
> Author: Diego Nicola Barbato <dnbarbato@posteo.de>
> Date: Fri Apr 6 13:43:54 2018 +0200
>
> gnu: libfive: Add snippet, enable tests and remove obsolete phase.
>
> * gnu/packages/engineering.scm (libfive)[source]: Add snippet to
> remove bundled catch.
[...]
> + (snippet
> + ;; Remove bundled catch since we provide our own.
> + '(delete-file "libfive/test/catch.hpp"))))
It would be good to try to avoid adding more phases or snippets that
return unspecified values. I fixed every snippet in 'core-updates', but
I guess more passes will be needed as these errors continue to be
introduced.
Mark
next parent reply other threads:[~2018-04-19 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180419095903.21090.36781@vcs0.savannah.gnu.org>
[not found] ` <20180419095904.D9E2D204EE@vcs0.savannah.gnu.org>
2018-04-19 12:26 ` Mark H Weaver [this message]
2018-04-19 15:19 ` 03/07: gnu: libfive: Add snippet, enable tests and remove obsolete phase Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87in8nidqp.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).