Could guix lint check the copyright line?

Could guix lint check the copyright line?

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

Wouldn't it be neat if guix lint would automatically spot missing
copyright lines in the file headers?  It could rely on `git blame' to
identify who wrote more than some 15 lines in a file.

What do you think?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: Could guix lint check the copyright line?

[ng0]

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

Pierre Neidhardt transcribed 907 bytes:
> Wouldn't it be neat if guix lint would automatically spot missing
> copyright lines in the file headers?  It could rely on `git blame' to
> identify who wrote more than some 15 lines in a file.

That's a really low threshold given that sometimes
people changed 2 or 3 lines in a file or 1 and still
get to add their copyright line. If we don't have it,
no one will complain I guess. And then we have to
distinguish author and commiter as well.
 
> What do you think?
> 
> -- 
> Pierre Neidhardt
> https://ambrevar.xyz/



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Could guix lint check the copyright line?

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

ng0 <ng0@n0.is> writes:

> That's a really low threshold given that sometimes
> people changed 2 or 3 lines in a file or 1 and still
> get to add their copyright line.

That's fine, we can also assign a copyright for 1 line.

> If we don't have it, no one will complain I guess. And then we have to
> distinguish author and commiter as well.

Copyright goes to author, not committer.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: Could guix lint check the copyright line?

[Ludovic Courtès]

Hi!

Pierre Neidhardt <mail@ambrevar.xyz> skribis:

> Wouldn't it be neat if guix lint would automatically spot missing
> copyright lines in the file headers?  It could rely on `git blame' to
> identify who wrote more than some 15 lines in a file.
>
> What do you think?

That check would have to be optional because ‘guix lint’ is not
necessarily running from a Git checkout.  Also, I wonder how frequent
false-positives would be.

Thanks,
Ludo’.