From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sIJdH2W9Vl93bQAA0tVLHw (envelope-from ) for ; Mon, 07 Sep 2020 23:08:21 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8GhAG2W9Vl9uSQAAbx9fmQ (envelope-from ) for ; Mon, 07 Sep 2020 23:08:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 280C6940876 for ; Mon, 7 Sep 2020 23:08:21 +0000 (UTC) Received: from localhost ([::1]:54150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFQFH-0001et-Sx for larch@yhetil.org; Mon, 07 Sep 2020 19:08:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFQEu-0001ej-Gp for guix-devel@gnu.org; Mon, 07 Sep 2020 19:07:56 -0400 Received: from cascadia.aikidev.net ([2600:3c01:e000:267:0:a171:de7:c]:48952) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFQEs-0005Y1-Or for guix-devel@gnu.org; Mon, 07 Sep 2020 19:07:56 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100b]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 2EE211AA3F for ; Mon, 7 Sep 2020 16:07:49 -0700 (PDT) From: Vagrant Cascadian To: guix-devel@gnu.org Subject: More checks for Makefile.am:assert-no-store-file-names ? Date: Mon, 07 Sep 2020 16:07:45 -0700 Message-ID: <87imcpfany.fsf@yucca> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: none client-ip=2600:3c01:e000:267:0:a171:de7:c; envelope-from=vagrant@debian.org; helo=cascadia.aikidev.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/07 19:07:49 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -1.61 X-TUID: xw6W13GYuwvk --=-=-= Content-Type: text/plain When running "make dist" there are some checks run, such as checking for hard-coded store paths. Would it be a good idea to add this or a similar check to etc/git/pre-push and/or guix lint? Would it make sense to set up a job to run "make dist" on the build farm to catch these problems? # Make sure we're not shipping a file that embeds a local /gnu/store file name. assert-no-store-file-names: $(AM_V_at)if grep -r --exclude=*.texi --exclude=*.info \ --exclude=*.info-[0-9] --exclude=*.dot \ --exclude=*.eps --exclude-dir=bootstrap \ --exclude=guix-manual.pot --exclude=guix-manual.*.po \ --exclude=guix-cookbook.pot --exclude=guix-cookbook.*.po \ --exclude=guix-prettify.el \ --exclude=ChangeLog* \ --exclude=binutils-boot-2.20*.patch \ -E "$(storedir)/[a-z0-9]{32}-" $(distdir) ; \ then \ echo "error: store file names embedded in the distribution" >&2 ; \ exit 1 ; \ fi Checking this more often could prevent: bug#43005: make dist fails: "store file names embedded in the distribution" It would be nice to catch these bugs earlier, especially when they are low down on dependency chain! live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCX1a9QQAKCRDcUY/If5cW quNLAP0YAYRafGYYNQ+g8EMdB8deTbAK+E54ThbNaCFbza6rpQEA/bzk8+Z+zIHE XYaO1EDbIwKqUhtaGqW02n1XwGmT4w4= =YD3V -----END PGP SIGNATURE----- --=-=-=--