From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qJx2A57oYV+GWAAA0tVLHw (envelope-from ) for ; Wed, 16 Sep 2020 10:27:42 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id cOTeOp3oYV+obAAAB5/wlQ (envelope-from ) for ; Wed, 16 Sep 2020 10:27:41 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C2AC49402DA for ; Wed, 16 Sep 2020 10:27:41 +0000 (UTC) Received: from localhost ([::1]:55802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIUf6-0000xM-Ob for larch@yhetil.org; Wed, 16 Sep 2020 06:27:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIUey-0000xF-Ih for guix-devel@gnu.org; Wed, 16 Sep 2020 06:27:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37240) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIUey-0005WM-0Y; Wed, 16 Sep 2020 06:27:32 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39278 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kIUew-0008S0-Oz; Wed, 16 Sep 2020 06:27:31 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Vagrant Cascadian Subject: Re: More checks for Makefile.am:assert-no-store-file-names ? References: <87imcpfany.fsf@yucca> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Jour de la Vertu de =?utf-8?Q?l'Ann=C3=A9e?= 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 16 Sep 2020 12:27:18 +0200 In-Reply-To: <87imcpfany.fsf@yucca> (Vagrant Cascadian's message of "Mon, 07 Sep 2020 16:07:45 -0700") Message-ID: <87imcenhix.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: oNRe9HewQKJK Hi! Vagrant Cascadian skribis: > When running "make dist" there are some checks run, such as checking for > hard-coded store paths. > > Would it be a good idea to add this or a similar check to > etc/git/pre-push and/or guix lint? > > Would it make sense to set up a job to run "make dist" on the build farm > to catch these problems? > > # Make sure we're not shipping a file that embeds a local /gnu/store file= name. > assert-no-store-file-names: > $(AM_V_at)if grep -r --exclude=3D*.texi --exclude=3D*.info \ > --exclude=3D*.info-[0-9] --exclude=3D*.dot \ > --exclude=3D*.eps --exclude-dir=3Dbootstrap \ > --exclude=3Dguix-manual.pot --exclude=3Dguix-manual.*.po \ > --exclude=3Dguix-cookbook.pot --exclude=3Dguix-cookbook.*.po \ > --exclude=3Dguix-prettify.el \ > --exclude=3DChangeLog* \ > --exclude=3Dbinutils-boot-2.20*.patch \ > -E "$(storedir)/[a-z0-9]{32}-" $(distdir) ; \ > then \ > echo "error: store file names embedded in the distribution" >&2 ; \ > exit 1 ; \ > fi > > Checking this more often could prevent: > > bug#43005: make dist fails: "store file names embedded in the distribut= ion" > > It would be nice to catch these bugs earlier, especially when they are > low down on dependency chain! This one was a bit of unusual case but yeah, it=E2=80=99d be nice to catch earlier anyway. I=E2=80=99m not sure where to test it though: =E2=80=98gui= x lint=E2=80=99 would miss some of the other issues, and a plain makefile rule might see too much. Probably the best thing to do is a =E2=80=9Cmake dist=E2=80=9D job under co= ntinuous integration, as you suggest. Thanks, Ludo=E2=80=99.