From: "Ludovic Courtès" <ludo@gnu.org>
To: Vagrant Cascadian <vagrant@debian.org>
Cc: guix-devel@gnu.org
Subject: Re: More checks for Makefile.am:assert-no-store-file-names ?
Date: Wed, 16 Sep 2020 12:27:18 +0200 [thread overview]
Message-ID: <87imcenhix.fsf@gnu.org> (raw)
In-Reply-To: <87imcpfany.fsf@yucca> (Vagrant Cascadian's message of "Mon, 07 Sep 2020 16:07:45 -0700")
Hi!
Vagrant Cascadian <vagrant@debian.org> skribis:
> When running "make dist" there are some checks run, such as checking for
> hard-coded store paths.
>
> Would it be a good idea to add this or a similar check to
> etc/git/pre-push and/or guix lint?
>
> Would it make sense to set up a job to run "make dist" on the build farm
> to catch these problems?
>
> # Make sure we're not shipping a file that embeds a local /gnu/store file name.
> assert-no-store-file-names:
> $(AM_V_at)if grep -r --exclude=*.texi --exclude=*.info \
> --exclude=*.info-[0-9] --exclude=*.dot \
> --exclude=*.eps --exclude-dir=bootstrap \
> --exclude=guix-manual.pot --exclude=guix-manual.*.po \
> --exclude=guix-cookbook.pot --exclude=guix-cookbook.*.po \
> --exclude=guix-prettify.el \
> --exclude=ChangeLog* \
> --exclude=binutils-boot-2.20*.patch \
> -E "$(storedir)/[a-z0-9]{32}-" $(distdir) ; \
> then \
> echo "error: store file names embedded in the distribution" >&2 ; \
> exit 1 ; \
> fi
>
> Checking this more often could prevent:
>
> bug#43005: make dist fails: "store file names embedded in the distribution"
>
> It would be nice to catch these bugs earlier, especially when they are
> low down on dependency chain!
This one was a bit of unusual case but yeah, it’d be nice to catch
earlier anyway. I’m not sure where to test it though: ‘guix lint’ would
miss some of the other issues, and a plain makefile rule might see too
much.
Probably the best thing to do is a “make dist” job under continuous
integration, as you suggest.
Thanks,
Ludo’.
prev parent reply other threads:[~2020-09-16 10:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 23:07 More checks for Makefile.am:assert-no-store-file-names ? Vagrant Cascadian
2020-09-16 10:27 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imcenhix.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=vagrant@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).