unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jan Nieuwenhuizen <janneke@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: guix-devel@gnu.org, 43922-done@debbugs.gnu.org
Subject: Re: [PATCH] installer: Add Emacs EXWM desktop environment. [WAS Re: Call for 1.2 installer testing.]
Date: Tue, 13 Oct 2020 21:26:31 +0200	[thread overview]
Message-ID: <87imbeexlk.fsf@gnu.org> (raw)
In-Reply-To: <87h7qym7v2.fsf@gnu.org> (Mathieu Othacehe's message of "Tue, 13 Oct 2020 18:02:57 +0200")

Mathieu Othacehe writes:

Hi Mathieu,

>> It works for me; I found Emacs EXWM missing however.  After zenny also
>> asked about that this morning, I decided to create a patch.
>
> Thanks for testing

Using it is real easy, pleasant, and fast.  One thing that I got wrong a
couple of times is to actually select a suggested option while
partitioning, I pressed TAB and RET (like in previous screens), then
selecting the button that is clearly marked EXIT.  Then it tries to
continue with a non-partitioned or badly partitioned drive, which then
may give an unexpected error.

Clearly a user error, not a problem and I also do not have a better
suggestion.  Also, my mistake was very obvious to me later.

> and for the patch!  I think it might be necessary to
> add "emacs-exwm" to "installation-target-os-for-gui-tests" in (gnu tests
> install) module.

Good call.  I verified that the test fails without it..

> To make sure that it's working fine you can run:
>
> make check-system TESTS="gui-installed-os gui-installed-os-encrypted
> gui-installed-desktop-os-encrypted"

--8<---------------cut here---------------start------------->8---
cannot build derivation `/gnu/store/7xnhrap7xsv2x717yn9wrgisxpppxrmy-emacs-27.1.drv': 1 dependencies couldn't be built
cannot build derivation `/gnu/store/kkfdhpc81h0f0sz0mj1ayin0sxy7vkmq-emacs-desktop-environment-0.3.0.drv': 1 dependencies couldn't be built
cannot build derivation `/gnu/store/3amvkhwa4jv8fghljgkcvlkpg4mpwc8v-emacs-exwm-0.24.drv': 1 dependencies couldn't be built
cannot build derivation `/gnu/store/q4pxd90hb9mah7cs9r1cjyb2pif1ixmz-emacs-xelb-0.18.drv': 1 dependencies couldn't be built
--8<---------------cut here---------------end--------------->8---

and veried that it passes when I adding them.

> Otherwise, it looks fine.

Thanks, pushed to master as 1197b8b20f4fca4ce03bbc5fa75e18d54e3717c0.

Greetings,
Janneke

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com


  parent reply	other threads:[~2020-10-13 19:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09 12:44 Call for 1.2 installer testing Mathieu Othacehe
2020-10-11 13:33 ` [PATCH] installer: Add Emacs EXWM desktop environment. [WAS Re: Call for 1.2 installer testing.] Jan Nieuwenhuizen
     [not found]   ` <87h7qym7v2.fsf@gnu.org>
2020-10-13 19:26     ` Jan Nieuwenhuizen [this message]
2020-10-13 16:40 ` Call for 1.2 installer testing Alex Sassmannshausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imbeexlk.fsf@gnu.org \
    --to=janneke@gnu.org \
    --cc=43922-done@debbugs.gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).