unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: Using #true and #false everywhere?
Date: Wed, 21 Oct 2020 12:04:30 +0200	[thread overview]
Message-ID: <87imb37v4h.fsf@gnu.org> (raw)
In-Reply-To: <87r1psumnx.fsf@elephly.net> (Ricardo Wurmus's message of "Wed, 21 Oct 2020 08:18:42 +0200")

Hi,

Ricardo Wurmus <rekado@elephly.net> skribis:

> Mark H Weaver <mhw@netris.org> writes:
>
>> Ricardo Wurmus <rekado@elephly.net> writes:
>>
>>> I think it’s very ugly that we still need to end phases with #T, even
>>> though build systems don’t care any more.  The only thing that aborts a
>>> build phase now is an exception.
>>
>> I would be glad if this were the case, but I believe you're mistaken.
>> On both master and core-updates, in (guix build gnu-build-system), the
>> 'gnu-build' procedure iterates over the phases using 'every', and
>> procedure passed to 'every' ends by returning 'result', which is the
>> value that the phase returned.  Am I missing something?
>
> No, you are correct.  My meaning was more about intent; in the early
> days of the change to INVOKE I’ve seen a couple of warnings telling me
> that a phase returned #<unspecified> or #F, but that didn’t result in
> aborting the build.  We have decided a long time ago that the only way
> to exit a build should be through an exception, so I think it’s time to
> update the last few build system remnants of the Boolean assumption (on
> core-updates).

I agree.  That means replacing ‘every’ with ‘for-each’.

Ludo’.


  reply	other threads:[~2020-10-21 10:04 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16 10:38 Using #true and #false everywhere? Ludovic Courtès
2020-10-16 13:19 ` Maxim Cournoyer
2020-10-16 13:36   ` Tobias Geerinckx-Rice
2020-10-18  1:36     ` Maxim Cournoyer
2020-10-18  2:22       ` Bengt Richter
2020-10-19 20:45       ` zimoun
2020-10-21  9:56         ` Ludovic Courtès
2020-10-20  9:57     ` Andreas Enge
2020-10-21  9:59       ` Ludovic Courtès
2020-10-21 11:21         ` Andreas Enge
2020-10-21 15:52           ` Ludovic Courtès
2020-10-21 11:51         ` Roel Janssen
2020-10-16 16:24 ` Vagrant Cascadian
2020-10-16 23:45 ` Danny Milosavljevic
2020-10-20 10:32 ` Andreas Enge
2020-10-20 11:10   ` Ricardo Wurmus
2020-10-20 12:02     ` zimoun
2020-10-20 12:59       ` Tobias Geerinckx-Rice
2020-10-20 13:11         ` zimoun
2020-10-20 13:32           ` Tobias Geerinckx-Rice
2020-10-20 14:26             ` zimoun
2020-10-20 15:48               ` Taylan Kammer
2020-10-21  1:25     ` Mark H Weaver
2020-10-21  6:18       ` Ricardo Wurmus
2020-10-21 10:04         ` Ludovic Courtès [this message]
2020-10-20 12:45   ` zimoun
2020-10-20 12:55     ` Andreas Enge
2020-10-21 10:20   ` Ludovic Courtès
2020-10-24 18:29 ` Robin Templeton
  -- strict thread matches above, loose matches on Subject: below --
2020-10-16 22:06 Miguel Ángel Arruga Vivas
2020-10-17  0:25 ` jbranso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imb37v4h.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).