From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id Ws6/Eg1umF/hXAAA0tVLHw (envelope-from ) for ; Tue, 27 Oct 2020 18:59:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id uKAlDg1umF/mUgAA1q6Kng (envelope-from ) for ; Tue, 27 Oct 2020 18:59:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DBA639400D3 for ; Tue, 27 Oct 2020 18:59:24 +0000 (UTC) Received: from localhost ([::1]:34992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXUBn-00047Y-T4 for larch@yhetil.org; Tue, 27 Oct 2020 14:59:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXUBC-00046X-4W for guix-devel@gnu.org; Tue, 27 Oct 2020 14:58:47 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:36248) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kXUB9-0008WV-Sw for guix-devel@gnu.org; Tue, 27 Oct 2020 14:58:45 -0400 Received: by mail-wr1-x444.google.com with SMTP id x7so3125616wrl.3 for ; Tue, 27 Oct 2020 11:58:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=43lPeKF3oaxJccyFf7epbptTWEk33e702hjXvGg0J5U=; b=q86HNf4MGlEbt4LmBV/SkTutw61viOFedmS41PAjKPWb9MzjgHEkFgt0wVb0lnvEbd LdXnRNrtXdIg4VjahPHLtK7wP/Iu7RxnTt9Fjl0hlchn7q6KOax2/wJKUFnxvVCUzWua C5gPqwL6OfBIslzaOqgYSvP9/Pba11GksAk3kI5RDIW6lKJDa485gnxyKc6HDBrDHDk0 JhQjDagXB2aBqboNi9ysJZ3Ma/BzcX7kB9pdy0Hkka8XSK82if+bUDSl+Nur7j7NnZaM U3rHc8FnLV8cQ2djX9uJdmrlWkCWdw0Fzycvq6Im1/k1SFzRNGWbYa+v6hMHkWoagA6a WUiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=43lPeKF3oaxJccyFf7epbptTWEk33e702hjXvGg0J5U=; b=eiIPShr7mVwvEsyCE03PDhQIh8paEIyyjzc7LUqpBBOyzgZaMAqsaCCJuhZ/xFt3u1 /5+/6VbrgimthWi6r/PIh+xpKmROXtvqlHaY9kbvlzD9Oqw2t5IPu78W7UrRLVJzFXAw dxC5B3InwlhmVyrb7mXuuQRZ/mfkqNaEE5dwxrLfrxgdisbMHrSVuAVV+tQnGGVRup9d uML7klkDDzKFaEQZtxlHGWvF+JfX/nOFqU0w1vWs9gI9KajWZeJRuAoKjBX6w0nZMj53 vm9rxRBWQjkg87EGl3A8I1E4t5kGHGUQ7md/ckfpOQWY77/1jL6Q0PV+KR4oMgNzCzao cf+A== X-Gm-Message-State: AOAM533QiXZ2KtdfGBnZgzMx/Cwy3yjoMf3UulX40mbZJi0R+WR2a3Wb c16l0kGRs+Fr+T0kNg8iutAPNlEo6N6jdQ== X-Google-Smtp-Source: ABdhPJwa5+kHHoSjPwM8b0PatE0kI7ozs6agXaVLDP4mNQwWrVwhALs7WhzFL+2EX01CJl7ocUquDA== X-Received: by 2002:a5d:6744:: with SMTP id l4mr4553095wrw.18.1603825122084; Tue, 27 Oct 2020 11:58:42 -0700 (PDT) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id l26sm2787974wmi.39.2020.10.27.11.58.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 11:58:40 -0700 (PDT) From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= To: Maxim Cournoyer Subject: Re: [PATCH v2] .dir-locals.el: Automatically set the GEISER-GUILE-LOAD-PATH variable. References: <87o8kqowa5.fsf@gmail.com> <20201026055316.25592-1-maxim.cournoyer@gmail.com> <877drdp68p.fsf@gmail.com> <87y2jrwqyv.fsf@gmail.com> Date: Tue, 27 Oct 2020 19:58:30 +0100 In-Reply-To: <87y2jrwqyv.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 27 Oct 2020 12:53:12 -0400") Message-ID: <87imavo5rd.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=rosen644835@gmail.com; helo=mail-wr1-x444.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=q86HNf4M; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -2.01 X-TUID: LrjPUF+d438h --=-=-= Content-Type: text/plain Hi Maxim! Maxim Cournoyer writes: > Thanks for your comments, they've already made this proposed change much > better! You did that, they only may have pointed somewhere, but the effort is yours, so thank you again. >> That cleanup seems to me responsibility of that .emacs maintainer >> instead of something to take into account in .dir-locals. ;-) > > Indeed, it could be seen that way! The good news is that it doesn't > seem to cause any problems anyway, should they forget an entry for Guix > there. Cool, one thing less to worry then. >> If there is some way this may happen, then this call is OK, but I'd try >> to stay with a cheaper push unless it's really needed, as O(1) < O(n), >> for almost every n. :-) > > The way I could easily trigger this was to open a dired buffer, and > hitting 'g' to refresh its contents. That usually is bind to revert-buffer, and they're being loaded again, so you're right. Was the definition for other modes intended? I didn't noticed because I copied directly the code onto scheme-mode sexp without looking at the context, what a reviewer... ;-P > I'll be sending a v3 with the fboundp woopsie above fixed. I've taken a look to v3 and LGTM. Even the answer to the question is no, I wouldn't send another patch only for that hypothetical change. Anybody can speak up if they have any objection; if they don't, I think you should push the patch. Happy hacking! Miguel --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEiIeExBRZrMuD5+hMY0xuiXn6vsIFAl+YbdcACgkQY0xuiXn6 vsKhewwAqji8HIE0t4TQY343AAkPJvnOzLNsjIlQiZxOHYA273N53cnTW7LDzQvU ZgpM0KyF7uITajZ0WDHkWI4mOlAXXXwiwGItSI9GlazF0WELOqlVgxtzmrrMEasA nubup11BWjfxIO25wUGABdH5k42EY/M5SkNZkn2dbii4AtLTiDuqCCPMw0phOUbH 2i2+b5k/Su5d68D6Z7+YrP0UXMpBxT2f3FWxK/1JKDAtE0hXfGq96Y1eSAKEQESR VPuFDjgzKfhsiIDTzxGWHOKCnEIZDiF7B4hiX4cJ08HqR9pLbVpeTZ+Egz6uAvBX ZnKxJKYzos4dmu8epCUJez2ftVQfywSc8kT8ScBVGcGP9/yeL3mqTqAOKMHGGkV8 O3nvRFDrTHhqGlgI2Qu5S3ktCPrsxYoht6vk1VmQQ1QH+MfDfsD00afdpZjNnlS3 nkUDC+CuBra3Esnb76oGUwmQajYBO7moAkaApT1RD8VDQsfZwLMuPwRq08LMgZ6m 0V0Ezf+r =i55G -----END PGP SIGNATURE----- --=-=-=--