From: "Miguel Ángel Arruga Vivas" <rosen644835@gmail.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v2] .dir-locals.el: Automatically set the GEISER-GUILE-LOAD-PATH variable.
Date: Tue, 27 Oct 2020 19:58:30 +0100 [thread overview]
Message-ID: <87imavo5rd.fsf@gmail.com> (raw)
In-Reply-To: <87y2jrwqyv.fsf@gmail.com> (Maxim Cournoyer's message of "Tue, 27 Oct 2020 12:53:12 -0400")
[-- Attachment #1: Type: text/plain, Size: 1451 bytes --]
Hi Maxim!
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Thanks for your comments, they've already made this proposed change much
> better!
You did that, they only may have pointed somewhere, but the effort is
yours, so thank you again.
>> That cleanup seems to me responsibility of that .emacs maintainer
>> instead of something to take into account in .dir-locals. ;-)
>
> Indeed, it could be seen that way! The good news is that it doesn't
> seem to cause any problems anyway, should they forget an entry for Guix
> there.
Cool, one thing less to worry then.
>> If there is some way this may happen, then this call is OK, but I'd try
>> to stay with a cheaper push unless it's really needed, as O(1) < O(n),
>> for almost every n. :-)
>
> The way I could easily trigger this was to open a dired buffer, and
> hitting 'g' to refresh its contents.
That usually is bind to revert-buffer, and they're being loaded again,
so you're right. Was the definition for other modes intended? I didn't
noticed because I copied directly the code onto scheme-mode sexp without
looking at the context, what a reviewer... ;-P
> I'll be sending a v3 with the fboundp woopsie above fixed.
I've taken a look to v3 and LGTM. Even the answer to the question is
no, I wouldn't send another patch only for that hypothetical change.
Anybody can speak up if they have any objection; if they don't, I think
you should push the patch.
Happy hacking!
Miguel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 658 bytes --]
next prev parent reply other threads:[~2020-10-27 18:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-25 18:08 [PATCH] Automatically set `geiser-guile-load-path' from .dir-locals Maxim Cournoyer
2020-10-25 18:13 ` Pierre Neidhardt
2020-10-25 18:42 ` [PATCH] .dir-locals.el: Automatically set the GEISER-GUILE-LOAD-PATH variable Maxim Cournoyer
2020-10-25 18:52 ` Pierre Neidhardt
2020-10-25 21:37 ` Maxim Cournoyer
2020-10-25 21:01 ` Miguel Ángel Arruga Vivas
2020-10-26 5:47 ` Maxim Cournoyer
2020-10-26 5:53 ` [PATCH v2] " Maxim Cournoyer
2020-10-26 7:56 ` Pierre Neidhardt
2020-10-26 11:38 ` Miguel Ángel Arruga Vivas
2020-10-27 16:53 ` Maxim Cournoyer
2020-10-27 18:58 ` Miguel Ángel Arruga Vivas [this message]
2020-10-27 17:44 ` [PATCH v3] " Maxim Cournoyer
2020-10-31 4:19 ` Maxim Cournoyer
2020-11-01 1:02 ` Miguel Ángel Arruga Vivas
2020-10-26 13:43 ` [PATCH] Automatically set `geiser-guile-load-path' from .dir-locals zimoun
2020-10-26 15:03 ` Pierre Neidhardt
2020-11-05 2:20 ` Christopher Lemmer Webber
2020-11-05 4:00 ` Christopher Lemmer Webber
2020-11-05 9:25 ` Miguel Ángel Arruga Vivas
2020-11-05 17:26 ` Christopher Lemmer Webber
2020-11-14 19:57 ` Christopher Lemmer Webber
2020-11-16 4:18 ` Maxim Cournoyer
2020-11-16 14:54 ` Miguel Ángel Arruga Vivas
2020-11-16 17:41 ` Christopher Lemmer Webber
2020-11-16 18:07 ` Christopher Lemmer Webber
2020-11-16 20:57 ` Miguel Ángel Arruga Vivas
2020-11-16 23:09 ` Christopher Lemmer Webber
2020-11-17 15:36 ` Maxim Cournoyer
2020-11-18 10:12 ` Miguel Ángel Arruga Vivas
2020-11-05 14:21 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imavo5rd.fsf@gmail.com \
--to=rosen644835@gmail.com \
--cc=guix-devel@gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).