From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wPY6OwRHYmCYbQEAgWs5BA (envelope-from ) for ; Mon, 29 Mar 2021 23:30:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YBwINQRHYmAVDQAAB5/wlQ (envelope-from ) for ; Mon, 29 Mar 2021 21:30:44 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 72C91CC18 for ; Mon, 29 Mar 2021 23:30:44 +0200 (CEST) Received: from localhost ([::1]:45638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQzT9-000455-FX for larch@yhetil.org; Mon, 29 Mar 2021 17:30:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQzSc-00043a-M1 for guix-devel@gnu.org; Mon, 29 Mar 2021 17:30:10 -0400 Received: from world.peace.net ([64.112.178.59]:36588) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQzSa-0004Ws-9T for guix-devel@gnu.org; Mon, 29 Mar 2021 17:30:10 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lQzSO-00068v-6k; Mon, 29 Mar 2021 17:29:56 -0400 From: Mark H Weaver To: Maxime Devos , guix-devel@gnu.org Subject: Re: [PATCHES] ImageMagick security updates without grafting In-Reply-To: <49232872faef1b3f5efed01816734c3bcf4e1b9b.camel@telenet.be> References: <878s68zqsd.fsf@netris.org> <927d66ccc760afacdb88485c5158731458d52dd6.camel@telenet.be> <87k0psdu25.fsf@netris.org> <9fb6ac4f0893446e3619d62395e035a446a9606f.camel@telenet.be> <875z1bdkmq.fsf@netris.org> <49232872faef1b3f5efed01816734c3bcf4e1b9b.camel@telenet.be> Date: Mon, 29 Mar 2021 17:28:18 -0400 Message-ID: <87im593b02.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.112.178.59; envelope-from=mhw@netris.org; helo=world.peace.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617053444; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=qM2LHl7Wf3NRX2FIeK3bWi+TqojyD2DWpKkpOnARA7Y=; b=svHUh4waeAetQQbtDCT9O1ft4QeXjTApRQJZsSrM4KPOAr4gJg0Hqgk+uCWiU0D4V7tnZR j/gMlz5dWO61VK3l6JsbdEQuqj/aMz2dyx6NiHl8JBvxQa9FcmFn3PHTqZi9Z1JXPIsrMD wKTluLUY9VyxHT1u7fdwz+EJAPfCfDAOc7UyByzIuOR7lwYVBDD16xZfeoULJ4goshiTIv pFaBIfQLejYWEeCIEQEsaICHs0VYh8GzLlTYY51o/5yoRsNSVo9diYvOhlb+5cHMKCETep OekMW9SjqhJoVGzkWeX7YhRVDuH8LCIN6nba6ZgLvYNBdXy102R1H2T34GuTsQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617053444; a=rsa-sha256; cv=none; b=u4ovWAsByfUqAbzAAYNccdW0fhZqQan5z/DNTUqlW9WPvSUclAwQgzGv6Ng+VI2txgiKDf tShCPNgiKeU7utAsbZw2tKxMvVd9DPWCXWKfMpnmf4viWNmJCO1FZ6Fel9CMdWSE6Pa9dO Dq072s5uZRb/Po05eQrcbKLYxrLHYz//V3RYVc/CBgYi56NRwI81lsGRIy9gNyPxrBU08i aNrnbubPSU5kkNNXfmtLTwZGRdxvgu3jeoPNb3HeeLj94tKrjOFgh4V4aKGOLmdJzcdMcJ DRk/zKL+n5xuGmKy8Yy3EAbBDG7i4oLVuR+aNn40RRdAEJDaFLEXd5UIzTDlJQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -0.92 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 72C91CC18 X-Spam-Score: -0.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: rZ37SnHOoILk Hi Maxime, Maxime Devos writes: > On Sun, 2021-03-28 at 17:37 -0400, Mark H Weaver wrote: >> One thing to be very careful about is to only use 'gtk-doc/stable', >> 'dblatex/stable', and 'imagemagick/stable' in native-inputs, and >> moreover to make sure that no references to these */stable packages >> remain in any package outputs. >> >> Of course, if any package retains references to its 'native-inputs', >> that's always a bug, but I wouldn't be surprised if such bugs exist in >> Guix. Such bugs might be relatively harmless now (except when >> cross-compiling), but they could become a security bug if a package >> retains a reference to 'imagemagick/stable'. > > I'll be careful! > >> On my own system and user profile, which includes GNOME, I'm glad to >> report that I have *no* references to 'imagemagick' at all, not even to >> its newest release, and that's my strong preference. > > Note to self, before I forget how to test this: > > guix build $PACKAGES > # maybe guix build $PACKAGES --no-grafts? > guix graph --type=references $PACKAGES > # ^ look in output for "imagemagick". For the record, it seems that this command gives false positives. As pointed out in , the output of that command suggests that 'inkscape' retains references to 'imagemagick', but that turns out to be false, at least on my system. I suppose the behavior of "guix graph" here makes sense, and is likely _not_ a bug, because IIUC "guix graph" does its work without requiring 'imagemagick' to be built, and therefore it cannot know whether imagemagick's build system would retain a reference to a native-input during its build process. IMO, it would be inappropriate for "guix graph" to *assume* that references to native-inputs will not retained. The tool I expect to be reliable here is "guix gc -R". For example, I check for references to 'imagemagick' in my system and user profiles with the following commands: --8<---------------cut here---------------start------------->8--- mhw@jojen ~$ guix gc -R $(readlink /run/current-system) | grep -i imagemagick mhw@jojen ~$ guix gc -R $(readlink -f ~/.guix-profile) | grep -i imagemagick --8<---------------cut here---------------end--------------->8--- Thanks, Mark