From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QJhCA1I2KWHNPQEAgWs5BA (envelope-from ) for ; Fri, 27 Aug 2021 21:00:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iOSKOlE2KWEURwAA1q6Kng (envelope-from ) for ; Fri, 27 Aug 2021 19:00:33 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 65F5C1B9B0 for ; Fri, 27 Aug 2021 21:00:33 +0200 (CEST) Received: from localhost ([::1]:33520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJh5c-0000MR-HI for larch@yhetil.org; Fri, 27 Aug 2021 15:00:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJh5M-0000Ln-6K for guix-devel@gnu.org; Fri, 27 Aug 2021 15:00:16 -0400 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]:40561) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJh5K-00006l-Fu for guix-devel@gnu.org; Fri, 27 Aug 2021 15:00:15 -0400 Received: by mail-qk1-x734.google.com with SMTP id t190so8265642qke.7 for ; Fri, 27 Aug 2021 12:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=XGkexDMOZ5Y8TJCfewTU6WEZ20s1NZYrSSXmaPR0LkM=; b=vKEKeilPtDJVboY7N/ay4X2gwxbLn9oXmHy+dRHSp1AuCj0lUdbF1+nW3m8mE7xeef GoyfssJRxhlr4eIXuRh61A/wAiohSh5UHZKW3dIU6xFFSw8Qx+qdDr+DX6v3sk6Ick9n CoVAqgeV/5pqvUs50FpF5zyDhK6eyxJWuugaG2b3GO80ne4J6tsFXPp8krpc3AvegK9D eG63zKbmuKPVUJY41o9ozkOhYSt1wGrdOs5hweLNsQSi+5kz4q8nV41z5i4X2DEslW/t pJrS+upORRraFWPDlIN6/l7Dzoctcq+J55qNxpKFlEtYHNwPMTuqMnZ59UvHZ3XjFd5n Ezag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=XGkexDMOZ5Y8TJCfewTU6WEZ20s1NZYrSSXmaPR0LkM=; b=FM98YS4XjxM9n8pSNCH/Ig/tTnx/7HvKrmjMnVmdY2McUDwpO72J172uQnqfvG8XAN qG+BVcmDvP/cMxlL7k93EveTYA1JIqng5Os9bbRyRclcXF49Oh+B+c4hHKiqWLBBJUjF pygMsGPoI9jOY6HTKW5/lnSQ6uXABoES+V6RRdGFTxwpg0YyC1Sp0FyQV5vC0kp97tu9 iSAJCJMA6iKzFcqskIEeqct+SCPPqL1QlrufIfBrqb3nYqkkORPUDSs33cGhpTmbVOyM x1DITiQU2bhjvf4nI/mj+fCKBuqmSN02Vb9sQxJFupJb8naDenaenc3G9TukUKYGcnag oivg== X-Gm-Message-State: AOAM531tNso2byR+ltLt5uKKNOVc78gt20zXSpmtMWuXX14q8Y5pu686 sbFAVhPTTPcX+kMrZjXnksm8wnEqHf8= X-Google-Smtp-Source: ABdhPJxhn+KrMlGOU0pvSr5pFpR7MvrkdGSrX38nbjHud+MUy4HKPTmOmIK9Lgida7LPbxHo5S6HKg== X-Received: by 2002:a05:620a:1e8:: with SMTP id x8mr10452864qkn.153.1630090813227; Fri, 27 Aug 2021 12:00:13 -0700 (PDT) Received: from hurd (dsl-205-151-56-126.b2b2c.ca. [205.151.56.126]) by smtp.gmail.com with ESMTPSA id d129sm5341630qkf.136.2021.08.27.12.00.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Aug 2021 12:00:12 -0700 (PDT) From: Maxim Cournoyer To: Chris Marusich Subject: Re: GNU Guix 1.3.0rc2 available for testing! References: <874kfdvuuu.fsf@gmail.com> <87r1ic5i3t.fsf@gmail.com> <87lf8h70zx.fsf@gmail.com> <87im2vs5cd.fsf@gmail.com> Date: Fri, 27 Aug 2021 15:00:11 -0400 In-Reply-To: <87im2vs5cd.fsf@gmail.com> (Chris Marusich's message of "Thu, 03 Jun 2021 01:46:42 -0700") Message-ID: <87ilzqsog4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::734; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qk1-x734.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630090833; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=XGkexDMOZ5Y8TJCfewTU6WEZ20s1NZYrSSXmaPR0LkM=; b=i3kPdqKnSGTyZA/Y+PydoVhPVt9hbaMQc52KixYWTAuCYsVMhkcn6zU0iLeklIYxN2h2uW 2UZdgzvmhBhnoSssWX45G7W8pyVSFDFMkOvAnRGJZ0gI8sOIxU9NUrYBaXkBor84DScxv4 dNufoLYZT2/DHoqsYUfNzt8w+tT3SrHbRwilXDs7kNxP2HIjzPQVz3hscVG+Pqd3wvc4IC a07QszsxHsifbWZviwFsK02CuUY/A8267kcmHSDhDMHkpNssE3ZJdtrlJT86LpFRTyyJO/ iJ6PmtuivxaWqNi53oevyBN8PB1voPU0XM9kzSaIhLc6sdZFGFujg/gWVqySRA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630090833; a=rsa-sha256; cv=none; b=ISKWBxk/6Dbb/SExg9tLERoH2BrPseBbvWChD9DE5jwjFikJ++A2pBRGKGUExaQSeUGZEW xJDn6pw++gntCOh22LWCWlqAW8H8zAIpzX67N5Pc3fZcpPKlVV0FYNGiTOPSaA/2k3oqJT /U8EH5ZdsYUg8uoNavRA7R3hxfPJ31QOEXRN4uKg99krpBe3BNVRNF3ojioQRqJ2HoCYrL FchSka9Wo091N5hJxsghA1lb+tYasMC2cO+GIhaCHtHCxnjVmUk7KYqJbvEnk0+PcQUVkR FSjb6rr1rtLx1Tq3211+KDMOagb4P2aJRsIJURS73bRzroVWZ+UWnZ21whXOhQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=vKEKeilP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -3.13 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=vKEKeilP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 65F5C1B9B0 X-Spam-Score: -3.13 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6mt5VnJnHpjn Hello Chris! Chris Marusich writes: [...] > I tested this, and it works. Thank you! I can now build the release > (with this change) and run the tests (make check) successfully; > tests/go.scm is just omitted from the tests to run. > > By chance, I noticed the following lines below what you added: > > if HAVE_GUILE_LIB > SCM_TESTS += tests/go.scm > endif > > if BUILD_DAEMON_OFFLOAD > SCM_TESTS += tests/offload.scm > else > EXTRA_DIST += tests/offload.scm > endif > > > I guess that if we omit tests/go.scm from SCM_TESTS, it not only means > that the test won't be run, but it also means the test won't get > included in the tarball distribution ("make dist"). Is that right? It > seems undesirable to omit this test from the distribution just because > the machine on which the distribution was built might have lacked the > library necessary to run the test. Someone who builds Guix from the > distribution might actually have that library installed and thus be able > to run the test. To ensure that this test always gets included in the > distribution, perhaps we should also add it to EXTRA_DIST like so: > > diff -u a/Makefile.am b/Makefile.am > --- a/Makefile.am 2021-05-11 11:09:31.000000000 -0700 > +++ b/Makefile.am 2021-06-02 12:55:06.134793001 -0700 > @@ -457,7 +457,6 @@ > tests/git-authenticate.scm \ > tests/glob.scm \ > tests/gnu-maintenance.scm \ > - tests/go.scm \ > tests/grafts.scm \ > tests/graph.scm \ > tests/gremlin.scm \ > @@ -505,6 +504,12 @@ > tests/uuid.scm \ > tests/workers.scm > > +if HAVE_GUILE_LIB > +SCM_TESTS += tests/go.scm > +else > +EXTRA_DIST += tests/go.scm > +endif > + > if BUILD_DAEMON_OFFLOAD > SCM_TESTS += tests/offload.scm > else > > What do you think? Well observed! I test with the following environment, with and without guile-lib, and could confirm that the tests/go.scm file was missing from the dist archive when guile-lib was not present. --8<---------------cut here---------------start------------->8--- guix environment --ad-hoc --pure autoconf@2.69 automake@1.16.2 bzip2@1.0.8 disarchive@0.2.1 gettext-minimal@0.20.1 glibc-utf8-locales@2.31 gnutls@3.6.15 graphviz@2.42.3 guile-avahi@0.4.0-1.6d43caf guile-gcrypt@0.3.0 guile-git@0.5.2 guile-json@4.5.2 guile-lzlib@0.0.2 guile-sqlite3@0.1.2 guile-ssh@0.13.1 guile-zlib@0.1.0 guile-zstd@0.1.1 guile@3.0.7 gzip@1.10 help2man@1.47.13 libgcrypt@1.8.5 pkg-config@0.29.2 po4a@0.63 sqlite@3.31.1 texinfo@6.7 util-linux@2.35.1 git sed gawk findutils diffutils perl coreutils grep automake autoconf gettext xz tar gzip make gcc-toolchain imagemagick help2man [env]$ ./bootstrap && ./configure && make -j32 && make dist --8<---------------cut here---------------end--------------->8--- There was a problem where these files had embedded file names: --8<---------------cut here---------------start------------->8--- guix-1.3.0rc2.5207-ce515/build-aux/config.guess:#!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/sh guix-1.3.0rc2.5207-ce515/build-aux/config.sub:#!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/sh guix-1.3.0rc2.5207-ce515/build-aux/install-sh:#!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/sh error: store file names embedded in the distribution --8<---------------cut here---------------end--------------->8--- I had not seen this issue and it'll need to be investigated. For now I disabled the check to get the dist archive produced. Pushed with 0f853ab7731da4784a24cad7b08d6b9b633f5787. Thank you! Maxim