unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: 03/06: style: Add support for "newline forms".
       [not found] ` <20220110140158.960BFC0DA1D@vcs2.savannah.gnu.org>
@ 2022-01-11 16:33   ` Tobias Geerinckx-Rice
  2022-01-18 14:56     ` Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: Tobias Geerinckx-Rice @ 2022-01-11 16:33 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

Hi Ludo'!

Sigh.  Sorry.  I know what this will sound like.  :-)

guix-commits@gnu.org 写道:
> +   ('base32 '(sha256 origin))

I know this is your style, but I would *really* prefer this to be:

> +   ('source '(package))

instead.

I know!  But wait!  I think that's defensible: for the same reason 
that we add a newline after arguments, these few extra columns 
give an (IMO) surprising amount of breathing room down the road.

Well, anyway, I'll shut up,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: 03/06: style: Add support for "newline forms".
  2022-01-11 16:33   ` 03/06: style: Add support for "newline forms" Tobias Geerinckx-Rice
@ 2022-01-18 14:56     ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2022-01-18 14:56 UTC (permalink / raw)
  To: Tobias Geerinckx-Rice; +Cc: guix-devel

Hi!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> guix-commits@gnu.org 写道:
>> +   ('base32 '(sha256 origin))
>
> I know this is your style, but I would *really* prefer this to be:
>
>> +   ('source '(package))
>
> instead.
>
> I know!  But wait!  I think that's defensible: for the same reason
> that we add a newline after arguments, these few extra columns 
> give an (IMO) surprising amount of breathing room down the road.

No strong opinion here, you may well be representing the majority, and
I’m fine with the change you propose.  :-)

There’s a couple of tests that will need to be adjusted but it should be
alright.

(Maybe a few months from now we’ll have additional switches, like
‘-x civodul’, ‘-x nckx’, who knows?  :-))

Ludo’.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-18 15:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <164182331757.10378.13440878503433702005@vcs2.savannah.gnu.org>
     [not found] ` <20220110140158.960BFC0DA1D@vcs2.savannah.gnu.org>
2022-01-11 16:33   ` 03/06: style: Add support for "newline forms" Tobias Geerinckx-Rice
2022-01-18 14:56     ` Ludovic Courtès

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).